Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add not_amazon tests to S3 engine #2909

Open
wants to merge 1 commit into
base: 10.6
Choose a base branch
from
Open

Add not_amazon tests to S3 engine #2909

wants to merge 1 commit into from

Conversation

LinuxJedi
Copy link
Contributor

Additional tests missed of an earlier pull request.

How can this PR be tested?

Run the S3 engine tests against MinIO.

Basing the PR against the correct MariaDB version

  • This is a new feature and the PR is based against the latest MariaDB development branch.
  • This is a bug fix and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

@LinuxJedi LinuxJedi force-pushed the s3-update branch 3 times, most recently from 4484b52 to f83d314 Compare December 14, 2023 16:33
@LinuxJedi
Add not_amazon tests to S3 engine
00ce1cb 
Additional tests missed of an earlier pull request. Also fixes Amazon
domain matching.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlenski dlenski dlenski left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@LinuxJedi @dlenski