MDEV-18478 ANALYZE for statement should show selectivity of pushed index condition #2899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dex condition Add runtime counters to ANALYZE FORMAT=JSON for the number of rows (r_rows_idx) and the number of rows that survive the pushed index condition (r_icp_filtered) under a new JSON object (r_index_condition). Changed r_lookups under rowid_filter to be an average number of lookups per r_loops, to make r_lookups and r_rows_idx consistent with r_rows. Added new test, and verified and modified results files of existing tests that use ANALYZE FORMAT=JSON.
165c93d
to
da6766a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add runtime counters to ANALYZE FORMAT=JSON for the number of rows (r_rows_idx) and the number of rows that survive the pushed index condition (r_icp_filtered) under a new JSON object (r_index_condition).
How can this PR be tested?
Added new test, and verified and modified results files of existing tests that use ANALYZE FORMAT=JSON.
If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually.
Basing the PR against the correct MariaDB version
PR quality check