Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDEV-30953: Add package for Galera server #2748

Draft
wants to merge 2 commits into
base: 11.5
Choose a base branch
from

Conversation

illuusio
Copy link
Contributor

@illuusio illuusio commented Sep 6, 2023

  • The Jira issue number for this PR is: MDEV-30953

Description

Add new package mariadb-server-galera to Debian to recude mariadb-server package dependencies. Galera cluster scripts and libraries are currently in package mariadb-server. Move Galera cluster scripts and libraries to new package mariadb-server-galera as most of the people does not need them and it allows to slim down mariadb-server package

How can this PR be tested?

As Salsa-CI is currently running out of space most of time (this should be addressed) this could check out:
branch: https://salsa.debian.org/illuusio/mariadb-server/-/pipelines/575821
11.3: https://salsa.debian.org/illuusio/mariadb-server/-/pipelines/575819
or build by hand in Debian sid with debian/autobake-deb.sh

This should also go thru MariaDB BB builds

Basing the PR against the correct MariaDB version

  • [x ] This is a new feature and the PR is based against the latest MariaDB development branch.

PR quality check

  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

Copy link
Member

@grooverdan grooverdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move and enable debian/additions/mariadb.conf.d/60-galera.cnf with "ON" settings.

[galera]
# Mandatory settings
wsrep_on                 = ON
wsrep_provider      = /usr/lib/galera/libgalera_smm.so
binlog_format            = row
innodb_autoinc_lock_mode = 2

#wsrep_cluster_name       = "MariaDB Galera Cluster"
#wsrep_cluster_address    = gcomm:https://
#default_storage_engine   = InnoDB

Uncommentted ones changed because they aren't the default. Need to test more if wsrep_cluster_address can be unset/blank.

Is RPM changes from #1829 moving here? Including change the CMakeLists.txt COMPONENT for every part here so that RPM is as close as possible.

TODO check is wsrep_provider path on MariaDB.org deb package is in the same path as debian, and ubuntu.

Also pv is an optional package used by SST.

debian/control Outdated Show resolved Hide resolved
debian/control Outdated Show resolved Hide resolved
@illuusio illuusio changed the title MDEV-30953: Add package new package for Galera server MDEV-30953: Add package package for Galera server Sep 6, 2023
@illuusio illuusio changed the title MDEV-30953: Add package package for Galera server MDEV-30953: Add package for Galera server Sep 6, 2023
@illuusio illuusio force-pushed the 11.3-MDEV-30953-mariadb-server-galera branch 2 times, most recently from a21e7e3 to 459b83c Compare September 11, 2023 07:36
@iangilfillan iangilfillan added the MariaDB Foundation Pull requests created by MariaDB Foundation label Sep 12, 2023
@illuusio illuusio force-pushed the 11.3-MDEV-30953-mariadb-server-galera branch 2 times, most recently from 157fcaf to 9cf1497 Compare October 16, 2023 07:31
@illuusio illuusio force-pushed the 11.3-MDEV-30953-mariadb-server-galera branch 3 times, most recently from 005e9f1 to f35d641 Compare October 23, 2023 06:29
@illuusio illuusio force-pushed the 11.3-MDEV-30953-mariadb-server-galera branch 4 times, most recently from fd5083a to c709042 Compare October 31, 2023 08:56
@illuusio illuusio force-pushed the 11.3-MDEV-30953-mariadb-server-galera branch from c709042 to 5ced31f Compare November 6, 2023 06:51
@illuusio illuusio changed the base branch from 11.3 to 11.4 November 6, 2023 06:53
@MariaDB MariaDB deleted a comment from CLAassistant Nov 6, 2023
@illuusio illuusio marked this pull request as draft November 6, 2023 06:54
@illuusio illuusio force-pushed the 11.3-MDEV-30953-mariadb-server-galera branch 2 times, most recently from 2314e6a to 2347f15 Compare November 15, 2023 08:59
@illuusio illuusio force-pushed the 11.3-MDEV-30953-mariadb-server-galera branch from 2347f15 to 39933a3 Compare November 24, 2023 12:19
@illuusio
Copy link
Contributor Author

Ok no it's working as expected. Galera is turned OFF when it's not installed. What should be done is to ask user or just enable things if Galera package is installed.

@illuusio illuusio force-pushed the 11.3-MDEV-30953-mariadb-server-galera branch from 39933a3 to 278b86d Compare December 4, 2023 07:22
@illuusio illuusio self-assigned this Jan 18, 2024
@illuusio illuusio force-pushed the 11.3-MDEV-30953-mariadb-server-galera branch from 278b86d to 8b75d2f Compare January 18, 2024 08:24
@illuusio illuusio force-pushed the 11.3-MDEV-30953-mariadb-server-galera branch from 8b75d2f to ee9e29d Compare February 19, 2024 06:34
@illuusio illuusio force-pushed the 11.3-MDEV-30953-mariadb-server-galera branch 2 times, most recently from fbbde46 to dace22c Compare March 27, 2024 07:58
@illuusio illuusio changed the base branch from 11.4 to 11.5 March 27, 2024 07:58
@MariaDB MariaDB deleted a comment from CLAassistant Mar 27, 2024
@CLAassistant
Copy link

CLAassistant commented Mar 27, 2024

CLA assistant check
All committers have signed the CLA.

@illuusio illuusio force-pushed the 11.3-MDEV-30953-mariadb-server-galera branch 3 times, most recently from f0893f6 to 31bde59 Compare March 27, 2024 11:03
Adds new package mariadb-server-galera and transfers
Galera cluster scripts and libraries have been
be in deb package mariadb-server.
Add new package MariaDB-server-galera to RPM based
distros like RHEL, Fedora and SuSE.
@illuusio illuusio force-pushed the 11.3-MDEV-30953-mariadb-server-galera branch from 31bde59 to 8a7d252 Compare May 2, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MariaDB Foundation Pull requests created by MariaDB Foundation
4 participants