Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix COLUMNSTORE in Debian CI builds #2651

Open
wants to merge 1 commit into
base: 11.1
Choose a base branch
from
Open

Fix COLUMNSTORE in Debian CI builds #2651

wants to merge 1 commit into from

Conversation

LinuxJedi
Copy link
Contributor

Debian building tried to implicitly enable ColumnStore, but it needs to be explicitly enabled to work. This should fix the AARCH64 BuildBot builders.

@LinuxJedi LinuxJedi requested a review from ottok as a code owner May 30, 2023 10:04
@LinuxJedi
Copy link
Contributor Author

Updated patch due to CMAKE_SYSTEM_PROCESSOR being arm64 on Debian 11 BuildBot, not aarch64.

@LinuxJedi
Copy link
Contributor Author

The reason why this broke in the first place was that the override that was supposed to enable ColumnStore on BuildBot Debian packaging builds was broken and now works.

This patch fixes a few things, but new BuildBot Debian autobake is still failing. This is due to missing Boost dependencies. I don't recommend reviewing / merging until this is fixed. Alternatively we should remove the BuildBot ColumnStore override in autobake-deb.sh so it is always off for Debian package builds.

This was referenced May 30, 2023
Merged
Open
ottok
ottok reviewed May 31, 2023
View reviewed changes
Copy link
Contributor

@ottok ottok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the changes I see now, the commit message should be:

Add `arm64` to the supported platforms for ColumnStore Debian buils

Debian build tried to implicitly enable ColumnStore on arm64, but for this
to work, the boost/flex dependencies need to be there.

@LinuxJedi
Copy link
Contributor Author

Based on the changes I see now, the commit message should be:

Add `arm64` to the supported platforms for ColumnStore Debian buils

Debian build tried to implicitly enable ColumnStore on arm64, but for this
to work, the boost/flex dependencies need to be there.

That isn't quite right though. ColumnStore has been supported on ARM64 Debian for a long time. We had a builder that should have been testing it but we found it wasn't working.

The commit message may change before this is merged.

@grooverdan
Copy link
Member

Part of the reason columnstore/CMakeLists.txt needed changing is debian/rules -DCMAKE_SYSTEM_PROCESSOR=$(DEB_HOST_ARCH) is a really dumb thing to do. Debian's architecture terms are so non-standard it was bound to be trouble.

@LinuxJedi LinuxJedi added the MariaDB Foundation Pull requests created by MariaDB Foundation label May 31, 2023
@fauust
Copy link
Contributor

fauust commented Mar 6, 2024 •
edited

@grooverdan please remember to update MariaDB/buildbot@6e20c37 once this is merged. Not sure how we could automate this and trigger an alert, but it would be very good.

@grooverdan
Copy link
Member

with #2893, cmake change no longer required.

@LinuxJedi
Fix COLUMNSTORE in Debian CI builds
bd71a5e 
Debian building tried to implicitly enable ColumnStore, but for this
to work, the boost/flex dependencies need to be there.

Also add `arm64` to the supported platforms for ColumnStore, that is
what it is identified as in Debian 11.
@LinuxJedi LinuxJedi assigned LinuxJedi and unassigned LinuxJedi May 8, 2024
@LinuxJedi LinuxJedi requested a review from grooverdan May 8, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ottok ottok ottok left review comments

@grooverdan grooverdan Awaiting requested review from grooverdan

Assignees

@grooverdan grooverdan

Labels
MariaDB Foundation Pull requests created by MariaDB Foundation
Milestone
No milestone
4 participants
@LinuxJedi @grooverdan @fauust @ottok