WIP : [MDEV-23962] Removed obsolete code to handle 'arc' directories #2537
Conversation
There was a problem hiding this comment.
Hi @is-this-echo, thanks for taking a look at this. I realize this is a work in progress still, but I just wanted to point out that in MDEV-23962 the request is not only to remove the mysql_rm_arc_files() etc., but to also make sure that the directories are being removed at some point in mysql_upgrade.
There was a problem hiding this comment.
This looks just about ready right? It could to with a small test case, that we could handle if you don't have time.
mysql-test/main/mysql_upgrade.test - create some files of arc names before MYSQL_UPGRADE and see if they are removed afterwards (which mysql-test will do by default anyway).
| @@ -18,6 +18,9 @@ | |||
|
|
|||
| #include "client_priv.h" | |||
| #include <sslopt-vars.h> | |||
| #include <my_dir.h> | |||
| #include <m_ctype.h> | |||
| #include "../include/mysql/psi/mysql_file.h" | |||
There was a problem hiding this comment.
#include <mysql/psi/mysql_file.h> seems sufficient elsewhere in the codebase.
| continue; | ||
| } | ||
| strxmov(filePath, org_path, "/", file->name, NullS); | ||
| if (mysql_file_delete_with_symlink(key_file_misc, filePath, "", MYF(MY_WME))) |
There was a problem hiding this comment.
my_delete is probably sufficient. key_file_misc is related to peformance schema and is really only for within the server.
Description
--WIP--
Deleted unused code to handle 'arc' directories in this files :
sql/sql_db.cc: find_db_tables_and_rm_known_files()
sql/sql_db.cc: mysql_rm_arc_files()
sql/parse_file.cc:rename_in_schema_file()
How can this PR be tested?
Basing the PR against the correct MariaDB version
PR quality check