Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MDBF-441: Add Lintian steps to DEB build #25

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

MDBF-441: Add Lintian steps to DEB build #25

wants to merge 2 commits into from

Conversation

illuusio
Copy link
Contributor

@illuusio illuusio commented Jul 5, 2022

Add steps to Lintian build to make sure that builds are not violating Debian packaging rules.

Why:

Lintian is a comprehensive package checker for Debian packages.

It tries to check for

  • Debian Policy violations and violations of various sub-policies,
  • best practices,
  • common mistakes,
  • and problems that maintainers like to catch before uploads.

@vladbogo
Copy link
Collaborator

buildbot wise looks good. @fauust @cvicentiu @grooverdan any other comments?

@fauust
Copy link
Collaborator

fauust commented Jul 18, 2022 •
edited

buildbot wise looks good. @fauust @cvicentiu @grooverdan any other comments?

Yes, see MariaDB/mariadb.org-tools#151 (comment)

I see two problems:

  • lintian package will make the images grow quite a lot (we probably can live with that);
  • some lintian decisions/rationales are "Debian Dev" decisions, and this can maybe make some Devs a bit unhappy so we probably need to make all lintian complains only warnings in the first place?

@fauust fauust mentioned this pull request Aug 10, 2022
Merged
@illuusio
MDBF-409: Add Lintian tool to Ubuntu/Debian docker images
f94afd8 
Add Lintian to Ubuntu/Debian docker build images so it will
be available to use within Buildbot Lintian step in future

Lintian is a comprehensive package checker for Debian packages
which tries to prevent common mistakes in Debian packages and
other packaging problems which are hard to spot with human
reviewing.
@illuusio
MDBF-409: Add Lintian step to master.cfg
19a0b90 
Add DebLintian step to master.cfg to make sure that
Lintian tool is getting launched everytime that BB is building
Debian packages. Lintian should be applied before DEB packages
are uploaded to further steps as Lintian can find problems
that are should not be there.
@illuusio
Copy link
Contributor Author

illuusio commented Dec 5, 2022

buildbot wise looks good. @fauust @cvicentiu @grooverdan any other comments?

Yes, see MariaDB/mariadb.org-tools#151 (comment)

I see two problems:

  • lintian package will make the images grow quite a lot (we probably can live with that);
  • some lintian decisions/rationales are "Debian Dev" decisions, and this can maybe make some Devs a bit unhappy so we probably need to make all lintian complains only warnings in the first place?

As I see this benefits over size growth is less than not have lintian. Currently most of MariaDB version goes thru Lintian just fine if we do not turn on most strict options.

@fauust
Copy link
Collaborator

fauust commented Feb 27, 2023

As said, the image size is not a pb IMO, just make sure that:

some lintian decisions/rationales are "Debian Dev" decisions, and this can maybe make some Devs a bit unhappy so we probably need to make all lintian complains only warnings in the first place?

@illuusio
Copy link
Contributor Author

You can

As said, the image size is not a pb IMO, just make sure that:

some lintian decisions/rationales are "Debian Dev" decisions, and this can maybe make some Devs a bit unhappy so we probably need to make all lintian complains only warnings in the first place?

One can turn off not needed test by --suppress-tags or from file --suppress-tags-from-file so should that be added? @grooverdan what do you think?

@grooverdan
Copy link
Member

@illuusio @fauust , I trust you to come up with some slow impact changes that will help QA on the Debian releases

@fauust fauust force-pushed the main branch 3 times, most recently from 87ffbbf to c75508d Compare March 2, 2023 14:43
@illuusio
Copy link
Contributor Author

@illuusio @fauust , I trust you to come up with some slow impact changes that will help QA on the Debian releases

Thank you for encouragement. As rpmlint got this should be in too so I'll work this with @fauust like everyone are happy with it.

@fauust fauust force-pushed the main branch 4 times, most recently from 4f49dd6 to e54c173 Compare October 24, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grooverdan grooverdan grooverdan approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@illuusio @vladbogo @fauust @grooverdan