Support more collection types + Able to set null value to nullable property + Value types will always be primitive #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lue types are always primitive
This reverts commit 3a59692.
eswann
added a commit
that referenced
this pull request
Jan 14, 2016
Support more collection types + Able to set null value to nullable property + Value types will always be primitive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for having more than one topic in single pull request. This is from my code base when I used Mapster for a while.
Current code base supports only array, List<>, generic interfaces such as IList<>, and ArrayList
With this pull request, it will support all ICollection<> implementation, such as HashSet<>, ObservableCollection<>.
And it also supports non-generic interfaces such as IList, ICollection, IEnumerable.
Current code base will never set null value to nullable property.
I think Mapper should map all possible values to target.
All value types, such as TimeSpan, DateTimeOffset, even custom struct should always be primitive.
Otherwise, it will error all cases when we map struct.
This should reduce a lot of custom config added to primitive types.