GUI rework #2
Merged
GUI rework #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Updates - Primary knobs & sliders are now smaller - Scope/visualisations are now smaller - GUI keyboard is now shorter but slightly wider - Spacing & borders made more uniform across the synth # To-Do - Still have to fix P5 canvases - Still have to work on theme functionality
# Styling - Border radius styling is now uniform across the synth - Background colours are now more uniform - Dropdown menu styling improved - Presets page spacing & colouring updated # Theme Functionality - Figured out how to switch in & out Tailwind CSS classes - Had to use a safelist array in Tailwind config - Light/dark mode toggle now toggles far more colours than before
# P5 - Now matches synth container again - Scopes realigned with designated areas # Oscilloscopes - Each oscilloscope now connected to a gain node to reduce size - Doubled the resolution of each oscilloscope - Oscillator volumes offset these gains to decrease natural scaling - Master oscilloscope added to FX scope - Attempted to add LFO oscilloscope (and failed) # Extra / Other - Increased volume of OSC C setters by 6 to closer match OSC A & B - Fixed newly discovered preset loading bug - Bug: values of 0 wouldn't update due to incorrect if statement
# Updates - Arpeggiator & master octave controls now theme properly - Readouts now theme properly too - Sadly required directly editing shadow root - Using same logic as other jQuery bits didn't work - Added colors property to each readout - Auto-indented index.html
- Modulation is now visualized to some degree - It's not great, but it's not terrible - Uses similar logic to the other oscilloscopes - But the Waveform object had to use maximum resolution - And the signal had to be adjusted a lot to get it working - This was due to the much lower frequencies LFOs oscillate at - As well as the fact that each LFO parameter interferes with it # Note: - Might be a bit more CPU/RAM hungry now - Due to the constant drawing of a waveform - Must remember to add a settings toggle for visualisations!
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Mangoshi
added a commit
that referenced
this pull request
Apr 30, 2023
- Last update worked with title and description, but not image - This is apparently because image only takes HTTP without :secure_url - Testing with :secure_url now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Ever since adding FM/AM controls to the oscillators, the synthesizer window was too big for the browser viewport.
This resulted in the GUI keyboard and bottom controls being obscured, which obviously isn't ideal!
What's new?
What's changed?