implement fractional hex #140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you rebase on main to solve conflicts ? |
a99fe95
to
284ba13
Compare
284ba13
to
3d2be43
Compare
|
Oops, we somehow got HEAD detached 😓 should be good now |
|
Yes, it does meet our requirements! Thank you for the reimpl, we aren't familiar with the codebase at all, so it was a sloppy-job-done :v Just recently switched to the library and found the feature missing. |
ManevilleF
added a commit
that referenced
this pull request
Jan 24, 2024
> Closes #138 > Supercedes #140 Re implementation of #140 by @msparkles I added CHANGELOG entries and some code clarifications. ## Work done Added the capacity to use *fractional axial coordinates* as `Vec2` in `HexLayout` methods: * Added `HexLayout::fract_hex_to_world_pos` method * Added `HexLayout::world_pos_to_fract_hex` method To avoid duplication and multi-method chaining I encapsulated the matrix computations in: * Added `HexOrientationData::forward` method * Added `HexOrientationData::inverse` method I also added these utility methods: * Added `Hex::to_array_f32` utility method * Added `Hex::to_cubic_array_f32` utility method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.