-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port Extension to Gnome 45 #3
Comments
Working on it. I think we will need a new branch for Gnome 45 pull requests |
do you happen to recall what with_pop_shell(callback) {
let pop_shell = Main.extensionManager.lookup("[email protected]");
if (pop_shell && pop_shell.stateObj) {
let ext = pop_shell.stateObj.ext;
if (ext) {
return callback(ext);
}
}
} A quick log of {
"metadata": {
"name": "Pop Shell",
"description": "Pop Shell",
"version": 2,
"uuid": "[email protected]",
"settings-schema": "org.gnome.shell.extensions.pop-shell",
"shell-version": [
"45"
]
},
"uuid": "[email protected]",
"type": 1,
"dir": {},
"path": "/usr/share/gnome-shell/extensions/[email protected]",
"error": "",
"hasPrefs": true,
"hasUpdate": false,
"canChange": true,
"sessionModes": [
"user"
],
"state": 1,
"isImported": true,
"stateObj": {
"metadata": {
"name": "Pop Shell",
"description": "Pop Shell",
"version": 2,
"uuid": "[email protected]",
"settings-schema": "org.gnome.shell.extensions.pop-shell",
"shell-version": [
"45"
],
"dir": {},
"path": "/usr/share/gnome-shell/extensions/[email protected]"
}
}
} |
Hello @snh1999, thank you for your help getting the extension working under Gnome 45! I have created a new branch for you to work on the new release: Branch To your question I can only recall what already is written in the comment above, that this section tries to evaluate if pop-shell is installed or not. I think the I'm very sorry if this is not so helpful... I have only forked the pop-cosmic extension and removed the unnecessary parts so I have not the deepest knowledge on how the extension works. Thank you again for helping me out! |
Sorry @ManeLippert, I was travelling last few days- so I didn’t get the chance to look at the code. |
@snh1999, no problem. Glad you have some time for doing this for the community. :) |
I am sorry, but I could not yet figure out a working solution. I think the changed how module(or extensions) are handled. I went through the pop-shell code for gnome 45, couldn't find any change that might cause breaking changes like that. I couldn't find any guide/a way to access it yet. |
@snh1999 no you do not have to be sorry. I am really glad you tried it! :) Because of all that reasons you mentioned, I am as well not able to port the extension, so I can understand your problems. |
As stated in the README I need someone who is willing to help me to port the extension to Gnome 45.
Pop-Launcher and Pop-Shell is compatible with Gnome 45 since Pop!_OS has updated the shell. But the Pop-COSMIC extension is not updated to Gnome 45 to this date. Because this extension originated from Pop-COSMIC I still need help with the port itself.
Guide
Pop!_OS 22.04
Pop-Launcher
Pop-Shell
Pop-COSMIC
The text was updated successfully, but these errors were encountered: