Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Extension to Gnome 45 #3

Open
ManeLippert opened this issue Sep 13, 2023 · 7 comments
Open

Port Extension to Gnome 45 #3

ManeLippert opened this issue Sep 13, 2023 · 7 comments
Labels
enhancement New feature or request

Comments

@ManeLippert
Copy link
Owner

ManeLippert commented Sep 13, 2023

As stated in the README I need someone who is willing to help me to port the extension to Gnome 45.

Pop-Launcher and Pop-Shell is compatible with Gnome 45 since Pop!_OS has updated the shell. But the Pop-COSMIC extension is not updated to Gnome 45 to this date. Because this extension originated from Pop-COSMIC I still need help with the port itself.

@snh1999
Copy link

snh1999 commented Nov 8, 2023

Working on it. I think we will need a new branch for Gnome 45 pull requests

@snh1999
Copy link

snh1999 commented Nov 8, 2023

do you happen to recall what pop_shell.stateObj.ext tries to access? This ext variable is getting undefined at this moment.

with_pop_shell(callback) {
        let pop_shell = Main.extensionManager.lookup("[email protected]");
        if (pop_shell && pop_shell.stateObj) {
            let ext = pop_shell.stateObj.ext;
            if (ext) {
                return callback(ext);
            }
        }
    }

A quick log of pop_shell variable showed.

{
    "metadata": {
        "name": "Pop Shell",
        "description": "Pop Shell",
        "version": 2,
        "uuid": "[email protected]",
        "settings-schema": "org.gnome.shell.extensions.pop-shell",
        "shell-version": [
            "45"
        ]
    },
    "uuid": "[email protected]",
    "type": 1,
    "dir": {},
    "path": "/usr/share/gnome-shell/extensions/[email protected]",
    "error": "",
    "hasPrefs": true,
    "hasUpdate": false,
    "canChange": true,
    "sessionModes": [
        "user"
    ],
    "state": 1,
    "isImported": true,
    "stateObj": {
        "metadata": {
            "name": "Pop Shell",
            "description": "Pop Shell",
            "version": 2,
            "uuid": "[email protected]",
            "settings-schema": "org.gnome.shell.extensions.pop-shell",
            "shell-version": [
                "45"
            ],
            "dir": {},
            "path": "/usr/share/gnome-shell/extensions/[email protected]"
        }
    }
}

@ManeLippert
Copy link
Owner Author

ManeLippert commented Nov 16, 2023

Hello @snh1999, thank you for your help getting the extension working under Gnome 45! ☺️

I have created a new branch for you to work on the new release: Branch

To your question I can only recall what already is written in the comment above, that this section tries to evaluate if pop-shell is installed or not. I think the ext variable tells the extension, which program should be invoked, when pressing the super key, because it is used so later in the code.

I'm very sorry if this is not so helpful... I have only forked the pop-cosmic extension and removed the unnecessary parts so I have not the deepest knowledge on how the extension works.

Thank you again for helping me out!

@ManeLippert ManeLippert added the enhancement New feature or request label Nov 16, 2023
@snh1999
Copy link

snh1999 commented Nov 27, 2023

Sorry @ManeLippert, I was travelling last few days- so I didn’t get the chance to look at the code.
I will be reporting updates on the project as soon as possible. Thank you🫡

@ManeLippert
Copy link
Owner Author

@snh1999, no problem. Glad you have some time for doing this for the community. :)

@snh1999
Copy link

snh1999 commented Dec 10, 2023

I am sorry, but I could not yet figure out a working solution.

I think the changed how module(or extensions) are handled. I went through the pop-shell code for gnome 45, couldn't find any change that might cause breaking changes like that. I couldn't find any guide/a way to access it yet.
Now I am looking through a discussion from Gnome Gitlab on that topic, if I don't find a way from that- I am probably out of options. Sorry again

@ManeLippert
Copy link
Owner Author

@snh1999 no you do not have to be sorry. I am really glad you tried it! :)

Because of all that reasons you mentioned, I am as well not able to port the extension, so I can understand your problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants