Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: catching classes that do not inherit from BaseException is not allowed #41

Open
ZanSara opened this issue Jun 5, 2023 · 1 comment

Comments

@ZanSara
Copy link
Contributor

ZanSara commented Jun 5, 2023

Since release 0.5.0, MissingOptionalDependency is no more an Exception, which breaks all usages such as:

try:
    import hello
except MissingOptionalDependency as e:
    ....

as they now raise:

TypeError: catching classes that do not inherit from BaseException is not allowed

I don't want to sound pushy, but this makes 0.5.0 a big breaking release and I'll downgrade to 0.3.1 until the issue is resolved or the intentions of this change are at least clarified, so that I can use the library properly.


As an aside, when you introduce "dangerous" changes, please do so in a PR, so in case of trouble I can track back what was happening, why and how should I adapt my code. Without any documentation to refer to or release notes or anything of this sort, I have no idea why the change was made and what to do now that my project is broken 😅

@Mandera
Copy link
Contributor

Mandera commented Jun 5, 2023

Oh wow, I'm sorry about this, definitely a mistake on my part and I appreciate your feedback! I'm working on improving these lacking areas

I'm releasing a hotfix 0.5.1 as a temporary measure for other users

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants