Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove static arrays #1697

Merged
merged 10 commits into from
Mar 4, 2022
Merged

remove static arrays #1697

merged 10 commits into from
Mar 4, 2022

Conversation

SimonDanisch
Copy link
Member

No description provided.

@MakieBot
Copy link
Collaborator

MakieBot commented Feb 24, 2022 •
edited
Loading

Compile Times benchmark

@SimonDanisch SimonDanisch mentioned this pull request Feb 25, 2022
Closed
@SimonDanisch
Copy link
Member Author

Funny, didn't think this would pass :D
This needs JuliaGeometry/GeometryBasics.jl#169 to fully remove staticarrays, but since this seems to be non breaking, we could also merge this before tagging JuliaGeometry/GeometryBasics.jl#169.
Definitely a nice simplification of used types on its own.
The above plot is from running the benchmarks locally on julia 1.9 with JuliaGeometry/GeometryBasics.jl#169 checked out.

@SimonDanisch
Copy link
Member Author

CI is a bit noisy and doesn't use the GeometryBasics branch, so I run the compile benchmark locally on julia master with all the right packages checked out.
Preserving this here for when CI overwrites the current plot:
image

@oscardssmith
Copy link
Contributor

Is this time difference changed by JuliaLang/julia#43990?

@SimonDanisch
Copy link
Member Author

SimonDanisch commented Feb 25, 2022 •
edited
Loading

Both already use JuliaLang/julia#43990

@SimonDanisch SimonDanisch force-pushed the sd/no-static-arrays branch 2 times, most recently from d076816 to 066f2d1 Compare March 4, 2022 10:25
@SimonDanisch SimonDanisch merged commit f2970dc into master Mar 4, 2022
@SimonDanisch SimonDanisch deleted the sd/no-static-arrays branch March 4, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Compile time improvements
done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SimonDanisch @MakieBot @oscardssmith