Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support STM with LL library, support ASCII chars directly, added much more glyphs #4

Merged
merged 7 commits into from
Sep 24, 2023

Conversation

Vinzenz82
Copy link
Contributor

Hello Coders,

I added following features:

sprintf(cData, "HELLO_-~");
Hello

sprintf(cData, "_-~coder");
coder

sprintf(cData, "_-~go~-_");
go

sprintf(cData, "~-_on_-~");
on

sprintf(cData, "start at");
start_at

sprintf(cData, "%2d-%2d-%2d", Now.hour, Now.minutes, Now.seconds);
clock

Tested with different controllers.

With best regards from germany,

Vinzenz Petr

@Hossein-M98
Copy link
Member

Hello Vinzenz
Thanks for your contribution.
I will check your changes and if everything is OK I will merge them into the main code.
Respectfully,
Hossein from Iran :)

Copy link
Member

@Hossein-M98 Hossein-M98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some problems that should be fixed before merging into the master branch:

  1. In the platform files, create a new platform for the STM32 LL library, instead of changing the previous STM32 HAL-compatible platform.
  2. Delete this part of the code. Because there are no hex numbers marked "g".
    image

Good luck

@Vinzenz82
Copy link
Contributor Author

Dear Hossein,

thank you very much for fast feedback and response. I removed the test code (0x40). In the platform code I already added a new target, look for TM1638_PLATFORM_STM32_LL. The original TM1638_PLATFORM_STM32 is still working with HAL and is not touched.

Best Regards,

Vinzenz

@Hossein-M98 Hossein-M98 merged commit f605090 into MahdaSystem:master Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants