Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sets in javascript #46

Merged
merged 3 commits into from
Jun 14, 2021
Merged

Sets in javascript #46

merged 3 commits into from
Jun 14, 2021

Conversation

pranavbharadwaj007
Copy link
Collaborator

added sets in javascript issue number #4

@pranavbharadwaj007
Copy link
Collaborator Author

resolved issue#4
@ManojSatishkumar

@ManojSatishkumar ManojSatishkumar added the enhancement New feature or request label Jun 13, 2021
@ManojSatishkumar ManojSatishkumar linked an issue Jun 13, 2021 that may be closed by this pull request
Explain javascript sets syntax and few examples #4
Closed
codeaholic-shub
codeaholic-shub reviewed Jun 13, 2021
View reviewed changes
Copy link
Collaborator

@codeaholic-shub codeaholic-shub left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well Done @pranavbharadwaj007 ,
Add README.md files too !

@pranavbharadwaj007
Copy link
Collaborator Author

@codeaholic-shub but y readme.md file its not wall of fame project its just the basic concept of sets.

darshanr27
darshanr27 approved these changes Jun 13, 2021
View reviewed changes
Copy link
Collaborator

@darshanr27 darshanr27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is fine.

@codeaholic-shub
Copy link
Collaborator

@codeaholic-shub but y readme.md file its not wall of fame project its just the basic concept of sets.

You can add so that as user enters they can see that and get an overview of yours work ,but if u don't ,its yours wish !

@darshanr27
Copy link
Collaborator

@codeaholic-shub but y readme.md file its not wall of fame project its just the basic concept of sets.

It's better if you add README.md, explaining what is Sets and methods of sets.

RishikaGhosh
RishikaGhosh approved these changes Jun 13, 2021
View reviewed changes
Copy link
Collaborator

@RishikaGhosh RishikaGhosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nice but I hope you will add a readme file.

@pranavbharadwaj007
Copy link
Collaborator Author

@RishikaGhosh @darshanr27 added readme file

RishikaGhosh
RishikaGhosh approved these changes Jun 13, 2021
View reviewed changes
Copy link
Collaborator

@RishikaGhosh RishikaGhosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

Sachin-chaurasiya
Sachin-chaurasiya approved these changes Jun 13, 2021
View reviewed changes
Copy link
Collaborator

@Sachin-chaurasiya Sachin-chaurasiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything Looks Good.
Great @pranavbharadwaj007

Sachin-chaurasiya
Sachin-chaurasiya approved these changes Jun 13, 2021
View reviewed changes
Copy link
Collaborator

@Sachin-chaurasiya Sachin-chaurasiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything Looks Good.
Great @pranavbharadwaj007

ParasPandey
ParasPandey approved these changes Jun 13, 2021
View reviewed changes
Copy link
Collaborator

@ParasPandey ParasPandey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

@ManojSatishkumar ManojSatishkumar merged commit 4efd11d into MSK-Web-development:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AKAspanion AKAspanion AKAspanion approved these changes

@ManojSatishkumar ManojSatishkumar ManojSatishkumar approved these changes

@darshanr27 darshanr27 darshanr27 approved these changes

@RishikaGhosh RishikaGhosh RishikaGhosh approved these changes

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

@codeaholic-shub codeaholic-shub codeaholic-shub approved these changes

@JyotiKumari2 JyotiKumari2 JyotiKumari2 approved these changes

@ParasPandey ParasPandey ParasPandey approved these changes

@Ajaykumbhare Ajaykumbhare Awaiting requested review from Ajaykumbhare

@anshul17024 anshul17024 Awaiting requested review from anshul17024

@harireddy7 harireddy7 Awaiting requested review from harireddy7

@keshavarora2000 keshavarora2000 Awaiting requested review from keshavarora2000

@mynameisankit mynameisankit Awaiting requested review from mynameisankit

@prykdev prykdev Awaiting requested review from prykdev

@revolution-99 revolution-99 Awaiting requested review from revolution-99

Assignees

@pranavbharadwaj007 pranavbharadwaj007

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explain javascript sets syntax and few examples
9 participants
@pranavbharadwaj007 @codeaholic-shub @darshanr27 @AKAspanion @ManojSatishkumar @RishikaGhosh @Sachin-chaurasiya @JyotiKumari2 @ParasPandey