Simplify Travis CI setup and parts of Python tests #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to concisely quantify differences in testing. Note that rtol and atol defaults for each function are different: - np.allclose: rtol=1e-05, atol=1e-08 - np.testing.assert_allclose: rtol=1e-07, atol=0
Also allow script to run in current directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few testing-related things going on with this PR. First, with Travis CI:
ctopythonto take advantage of built-in features for that language; there is no advantage of usingc(alsofortranis not a supported language)apt: truecacheFCenvironment variable to control gfortran version and symbolic link identified by pymakeAnd with the Python testing:
assert np.allclosewithnp.testing.assert_allclose, which provides a nice concise output of differences (if necessary). This required specifying thertol=1e-05in a few places for some tests to behave the same asnp.allclose.UZT_NonEq/insert_stopflow_period.pyto use conventional Python features. It also now works with Python 2.7 (if that's needed)