Use Travis CI to check for compilation warnings #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add these flags (based on previous commits to clean up warnings):
-Werror : Treat all warnings as errors, so it shows info in Travis CI
-Wtabs : Nonconforming tab characters
-Wline-truncation : truncated source lines (similar, but not quite
the same as `ifort -warn truncated_source`)
Fix by matching type from openspec.inc/FILESPEC.INC
langevin-usgs
approved these changes
Mar 8, 2019
There was a problem hiding this comment.
I like this. I think it would be great to implement, especially for you Windows people who don't realize the hassles associated with tabs. I tried to implement it for MODFLOW 6, but ran into some issues that I couldn't resolve. These flags did help me find and fix some issues with string assignments, but in the end I couldn't get it to work with all flavors of gfortran, though I may try again at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows Travis CI to compile and perform specific checks on the consistency of code, and ideally guard against introducing "bad code". This is done by passing FFLAGS to pymake, specifically
-Werrorwhich treats all warnings as errors, and fails the Travis CI with a log of compilation steps and errors, which is handy to see.So far, I've added a few specific warnings flags from previous commits for tabs. And added to this PR is
-Wcharacter-truncation, as there was a minor discrepancy between the data types.When potential issues are resolved in the code for each warning type (docs here), then that flag can be added to
fflagsinautotest/config.pyfor testing on Travis CI.