fix(ArrayReaders): Fix issue reading binary 2d arrays #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
up of constants specified in code (DZERO and DONE) instead of relying on constants module.
allocated using the memory manager. Also fixed issue with SEGFAULT in mf5to6 that was related to a pointer in ChdPackageWriter that was not pointed to null (=> null()) in definition.
test016_Keating_disu_250.
test016_Keating_disu_250. (2)
require successful testing of gfortran-7 and gfortran-8 environments.
Added section for current release and added header for 6.0.3 version changes.
Updated CONTRIBUTING.md and added DEVELOPER.md. DEVELOPER.md probably still needs additional work.
Fix issue reading binary 2d arrays. read_binary_header was imbedded in the row loop of the 2d readers. Modify test_gwf_binaryinput01 to create binary files for strt, idomain, botm, and icelltype for models with layered and non-layered cases.
|
This looks good, @jdhughes-usgs. I don't know how those header reads were inside the row reading loop or how it ever worked. The tests pass, so I'm going to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #40