refactor(prp): factor out routine for particle release #1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
wpbonelli
added a commit
that referenced
this pull request
Jul 3, 2024
#1907 erroneously converted a cycle condition to an error — this was left over from a more involved refactor which that PR was extracted from, and should not have been included yet. This has caused one of the PRT example models to fail, which has not shown up on this repository's CI because PRT notebook tests were getting skipped due to missing dependencies. This is behind the currently failing FloPy MF6 CI. This PR drops test_prt_notebooks.py in favor of just running the mf6 examples repo's own tests in CI. This is done only on Linux to avoid slowing things down too much, it should not add to total runtime if the runner pool is unsaturated because the modified jobs are still faster than the parallel test jobs. A few dependencies needed by the examples are added to the pixi and conda environments: * pooch * rasterio * rasterstats A subsequent PR will include more extensive cleanup of the release mechanism.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanup in the particle release package. More consistent variable names. Factor out routines to calculate release time and release the particle. Also, add a value 0 -> "default" for the
DEV_EXIT_SOLVE_METHODoption, and defer the selection of a default root-finding algorithm to the ternary method rather than the PRP package.Checklist of items for pull request
fprettify