feat(prp): support coordinate transformations #1901
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@langevin-usgs this is generally according to our outline |
wpbonelli
force-pushed
the
prt-local
branch
3 times, most recently
from
f7b8c52
to
0cb9b66
Compare
|
This should be ready for a look when @aprovost-usgs is back |
There was a problem hiding this comment.
I know there may be more on work on this, but just wanted to mention one comment about the release notes. I'm good with whatever you and @aprovost-usgs decide on the coordinate options.
doc/ReleaseNotes/develop.tex
Outdated
| @@ -27,6 +27,7 @@ | |||
| \item Previously the PRT model's default behavior was to track particles until termination, as with MODPATH 7 stop time option 2 (extend). Under extended tracking, the program may not halt if particles enter a cycle in the flow system. This PR changes the default to the equivalent of MP7 stop time option 1 (final), terminating at simulation end unless a new Particle Release Point (PRP) package keyword option EXTEND\_TRACKING is provided. This is meant to provide a stronger guarantee that the program halts under default settings. | |||
| \item A refactor of the energy storage and transfer (EST) package associated with the GWE model type results in different input requirements that breaks backward compatibility with what was required in version 6.5.0. The PACKAGEDATA block was removed from the EST package input. In its place, the heat capabity of water, the specified density of water, and the latent heat of vaporization are instead given default values that can be overridden by specifying alternative values in the OPTIONS block. | |||
| \item The PRT model's cell face flows were improperly combined with boundary flows; for cell faces with active neighbors, the face flow replaced any boundary flows (likely a rare situation because IFLOWFACE is typically applied to faces on the boundary of the active domain). The face flow calculation has been corrected. | |||
| \item Previously the PRT model's PRP package required release points to be specified in the model coordinate system (except for the z coordinate via the LOCAL\_Z option). PRT also previously reported pathlines in the model coordinate system. The PRT model now supports coordinate transformations for release point input and pathline output via keyword options for the PRP package, while preserving the existing default model coordinate system. Release point x and y coordinates may now be specified for structured grids with reference to the local rectilinear cell (with coordinates scaled to the unit interval) via the LOCAL\_XY keyword option. The LOCAL\_XY\_OFFSET option, supported for structured or unstructured grids, can be used to locate release point x and y coordinates at an offset from the cell center (with no distance rescaling). A development option DEV\_GLOBAL\_XY is also provided, enabling transformation of release points from (and pathline points to) the global coordinate system for georeferenced grids. | |||
There was a problem hiding this comment.
I don't think we should include DEV options in the release notes.
There was a problem hiding this comment.
OK, I will remove it. This PR will probably see some updates, @aprovost-usgs had a nice idea to re-interpret LOCAL_XY for vertex grids.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously PRT required particle release points (except for z via
LOCAL_Z) to be specified in the model coordinate system, and reported pathlines in the same coordinate system. This PR enables input and output coordinate transformations with keyword options for the PRP (particle release point) package.With this change, points may be specified as
LOCAL_XYand/orLOCAL_Z— only structured gridsLOCAL_XY_OFFSET— structured or unstructured gridsDEV_GLOBAL_XY— transform release points to model coordinates using grid georeference informationChecklist of items for pull request
fprettify