Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prt): sum boundary and face flows when loading cell #1900

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

wpbonelli
Copy link
Contributor

@wpbonelli wpbonelli commented Jun 26, 2024

Previously cell face flows were not properly summed with boundary flows, rather for cell faces with active neighbors, the face flow replaced any boundary flows. The reason this has gone unnoticed til now is probably that IFLOWFACE is typically applied to faces on the boundary of the active domain.

Also factor out a subroutine to load face flows into the cell definition — could be pulled into base MethodType but it is a small amount of duplication and implementations may diverge


Checklist of items for pull request

  • Formatted new and modified Fortran source files with fprettify
  • Updated develop.tex with a plain-language description of the bug fix, change, feature; required for changes that may affect users
  • Removed checklist items not relevant to this pull request

@wpbonelli wpbonelli added the bug label Jun 26, 2024
@wpbonelli wpbonelli marked this pull request as ready for review June 26, 2024 04:15
@wpbonelli wpbonelli merged commit f598f4c into MODFLOW-USGS:develop Jun 26, 2024
18 checks passed
@wpbonelli wpbonelli deleted the prt-fflows branch June 26, 2024 12:45
@wpbonelli wpbonelli added the code refactor Nonfunctional changes label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug code refactor Nonfunctional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant