refactor(sfr): implement submodules for SFR flow methods #1896
Conversation
There was a problem hiding this comment.
I like the submodules, and after reading about them, they do offer nice compiling benefits as well as better organization. I added a few annoying comments about naming in case we want to fine tune that a bit, but going with what's here now is also fine by me.
Since we are moving into submodules, we should probably add a section to the style guide under development in #1895 at some point.
| !> @brief Method for solving for standard reaches | ||
| !! | ||
| !! Method to solve the continuity equation for a SFR package | ||
| !! reach using the standard approach. |
There was a problem hiding this comment.
Is this routine description correct? Seems like it should describe how we solve for constant stage reaches?
src/meson.build
Outdated
| @@ -162,6 +162,8 @@ modflow_sources = files( | |||
| 'Model' / 'GroundWaterFlow' / 'gwf-uzf.f90', | |||
| 'Model' / 'GroundWaterFlow' / 'gwf-vsc.f90', | |||
| 'Model' / 'GroundWaterFlow' / 'gwf-wel.f90', | |||
| 'Model' / 'GroundWaterFlow' / 'submodules' / 'sm-gwf-sfr-steady.f90', | |||
There was a problem hiding this comment.
If these are already in a folder named submodules, do they need an "sm" prefix in the file name? Maybe we can drop the "sm"?
| @@ -0,0 +1,305 @@ | |||
| submodule(SfrModule) sm_gwf_sfr_steady | |||
There was a problem hiding this comment.
Just throwing this out there for discussion -- if the submodule is part of SfrModule, then does the submodule name need to include "gwf_sfr" in it? (as a separate note, we probably need to rename SfrModule to GwfSfrModule at some point to be consistent with other parts of the code).
In following with our other naming conventions, should the submodule name, then be SteadySubmodule since it by definition determined to part of gwf_sfr?
| !! | ||
| !< | ||
| module subroutine sfr_calc_constant(this, n, d1, hgwf, qgwf, qd) | ||
| ! -- dummy variables |
There was a problem hiding this comment.
Minor annoying comment -- if we are ditching the "--" in comments, maybe start off fresh with these two new submodule files?
jdhughes-usgs
force-pushed
the
sfr-refactor
branch
from
f706d70
to
a64fe95
Compare
Checklist of items for pull request
fprettifyFor additional information see instructions for contributing and instructions for developing.