test(prt): omit name field (object dtype) from snapshots #1887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NumPy 2.0.0 changes the way arrays with object dtype are pickled: https://numpy.org/devdocs/release/2.0.0-notes.html#highlights
wpbonelli
added a commit
to modflowpy/flopy
that referenced
this pull request
Jun 19, 2024
Remove NumPy upper bound to close #2153. Also fix `@requires_pkg` usage in `test_export.py`, replace deprecated `itemset` in `mfdatastorage.py`, and bump some CI jobs to Python 3.9. This PR required updates on the MF6 side: * test(test_gwf_maw04.py): switch deprecated np.unicode_ -> np.str_ MODFLOW-USGS/modflow6#1886 * test(prt): omit name field (object dtype) from snapshots MODFLOW-USGS/modflow6#1887
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NumPy 2.0.0 changes the way arrays with object dtype are pickled: https://numpy.org/devdocs/release/2.0.0-notes.html#highlights. Workaround is to keep snapshots numeric and check string/object columns explicitly when needed: MODFLOW-USGS/modflow-devtools@1883647.
Checklist of items for pull request
blackon new and modified autotests