ci: add pixi task to fix the format and spelling (fix-style) #1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpbonelli
reviewed
Jun 18, 2024
pixi.toml
Outdated
| @@ -48,9 +48,10 @@ install = { depends_on = [ | |||
| ] } | |||
|
|
|||
| # format | |||
| check-format = "python .github/common/check_format.py" | |||
| check-format = "echo 'Checking format...'; python .github/common/check_format.py" | |||
There was a problem hiding this comment.
I'm fine with this as is, though I wonder about letting the user pass -v/--verbose to the format and spelling scripts if they want to see output. Might be situations where we'd prefer no output on success. But the scripts will need slight modification too to accommodate that (they currently show some limited output even on success)
jdhughes-usgs
force-pushed
the
update-pixi
branch
from
f0549cc
to
fd52a35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist of items for pull request
For additional information see instructions for contributing and instructions for developing.