fix(prt): multiple fixes #1874
Merged
fix(prt): multiple fixes #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pollock and ternary methods could hang when a particle should terminate due to no exit face. This was because we failed to set the advancing flag to false. Entangled with this, the ternary method could erroneously terminate a particle and report no exit face (as described above, previously this would hang) due to precision error in the exit time/location calculation when two conditions obtain simultaneously: the particle enters the subcell extremely close to one of its vertices, and flow very nearly parallels one of the subcell's faces. We have encountered similar situations before, solved by nudging the particle some small distance into the interior of the subcell before applying the subcell tracking method. This particular case is resolved by increasing the nudge distance from (machine precision * 100) to (machine precision * 10000). Perhaps in future the nudge distance could be scaled by the size of the subcell.
wpbonelli
added a commit
to wpbonelli/modflow6
that referenced
this pull request
Jun 14, 2024
langevin-usgs
added a commit
that referenced
this pull request
Jun 15, 2024
* docs(release): mention #1865 in release notes * mention #1874 in release notes --------- Co-authored-by: langevin-usgs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pollock and ternary methods could hang when a particle should terminate due to no (sub)cell exit face. This occurred because an
advancingflag was not set in the proper location.Entangled with this, the ternary method could erroneously terminate a particle and report no exit face (as described above, previously this would hang) due to precision error in the exit time/position calculation. This could happen when two conditions are both met: the particle enters the subcell very close to one of its vertices, and flow very nearly parallels one of the subcell's faces. We have encountered similar situations before, solved by nudging the particle a small distance into the interior of the subcell before applying the tracking method. This particular case is resolved by increasing the padding distance from
DSAMEtoDSAME * 1000, i.e. machine precision * 10^5.I will plan to update release notes in #1871