Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(netcdf): support model ugrid layered mesh exports #1868

Merged
merged 18 commits into from
Jun 26, 2024

Conversation

mjreno
Copy link
Contributor

@mjreno mjreno commented Jun 12, 2024

  • DIS/DISV GWF/GWE/GWT models supported
  • All data written as layered variables
  • Dependent model variable exported with EXPORT_NETCDF UGRID name file option
    • No other options or configuration required beyond this option
  • GRIDDATA input arrays written with package option EXPORT_ARRAY_NETCDF
  • Grid mapping variable added by configuring NCF6 package with OGC_WKT option
    • All export arrays associated with mesh
  • Additional NCF6 options:
    • DEFLATE <integer> (per variable compression 0-9)
    • SHUFFLE keyword (variable byte shuffling which can improve compression)
      • only applied with DEFLATE option provided
    • CHUNKING_UGRID record (per variable time and face dimension chunk sizes)
  • Unsupported release so no documentation yet included
  • Extended executable CI test added
    • Linux/MacOS tests included, Windows not yet tested

@mjreno mjreno marked this pull request as draft June 12, 2024 13:48
@mjreno mjreno force-pushed the odm3 branch 2 times, most recently from c8db1ff to 299d898 Compare June 19, 2024 14:16
@mjreno mjreno marked this pull request as ready for review June 20, 2024 02:10
Copy link
Contributor

@langevin-usgs langevin-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One minor comment about testing, but think it can be handled later.

@@ -0,0 +1,568 @@
"""
Test problem for GWE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this model is the same as test_gwe_cnd, is it possible to just import build_models, etc. from the test_gwe_cnd python source file? I think that's how some of the parallel tests are constructed. Would need some way to inject the export_array_netcdf=True into the relevant packages. Just a suggestion as a way to remove duplication. Comment applies to the other tests as well, but maybe best left for a subsequent PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree something along those lines would be a better approach to eliminate the redundancy and improve maintainability. I'll plan to make these updates soon.

@langevin-usgs langevin-usgs merged commit 63e79f6 into MODFLOW-USGS:develop Jun 26, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants