Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sfr): update budget and table output for inactive reaches #1729

Merged
merged 4 commits into from
Apr 18, 2024

Conversation

jdhughes-usgs
Copy link
Contributor

Add evaluation of DHNOFLO value in tables

Add evaluation of DHNOFLO value in tables
@jdhughes-usgs jdhughes-usgs marked this pull request as draft April 15, 2024 22:29
@jdhughes-usgs
Copy link
Contributor Author

Tables with inactive reaches

SFR_0 PACKAGE - SUMMARY OF FLOWS FOR EACH CONTROL VOLUME   PERIOD      2   STEP        1
 ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
                                                                                                                                                                     PERCENT   
   NUMBER   CELLID                  INFLOW      OUTFLOW        GWF        RAINFALL   EVAPORATION     RUNOFF     EXT INFLOW  EXT OUTFLOW    STORAGE      IN - OUT    DIFFERENCE 
 ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
     1      (1,1,1)               0.0000       0.0000       0.81454      1.0000      -1.0000       1.0000       1.0000      -2.8145       0.0000       0.0000       0.0000     
     2      (1,1,1)               0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000     
 ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------



 SFR PACKAGE (SFR_0) STAGES FOR EACH CONTROL VOLUME   PERIOD      2   STEP        1
 -------------------------------------------------------------------------------------------------------------
                                                                                      STREAMBED    STREAMBED  
   NUMBER   CELLID                  STAGE        DEPTH        WIDTH       GWF HEAD   CONDUCTANCE    GRADIENT  
 -------------------------------------------------------------------------------------------------------------
     1      (1,1,1)               0.18546      0.18546      1.0000       1.0000       1.0000      -0.81454    
     2      (1,1,1)                INACTIVE     INACTIVE     INACTIVE    1.0000        INACTIVE     INACTIVE  
 -------------------------------------------------------------------------------------------------------------

@jdhughes-usgs
Copy link
Contributor Author

Updates on the tables

Stress period 1 with dry reach 1

SFR-1 PACKAGE - SUMMARY OF FLOWS FOR EACH CONTROL VOLUME   PERIOD      1   STEP        1
 --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
                                                                                                                                                                                               PERCENT   
   NUMBER   CELLID                  INFLOW      OUTFLOW        GWF        RAINFALL   EVAPORATION     RUNOFF     EXT INFLOW  EXT OUTFLOW    STORAGE      FROM MVR      TO MVR      IN - OUT    DIFFERENCE 
 --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
     1      NONE                  0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000     
     2      (1,1,1)               0.0000       0.0000       0.92094      0.0000       0.0000       0.0000       0.0000      -0.92094      0.0000       0.0000       0.0000       0.0000       0.0000     
     3      (1,1,1)               0.0000      -2.8145       0.81454      1.0000      -1.0000       1.0000       1.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000     
     4      (1,1,1)               2.8145       0.0000       0.72502      1.0000      -1.0000       1.0000       0.0000      -4.5396       0.0000       0.0000       0.0000       0.0000       0.0000     
 --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------



 SFR PACKAGE (SFR-1) STAGES FOR EACH CONTROL VOLUME   PERIOD      1   STEP        1
 -------------------------------------------------------------------------------------------------------------
                                                                                      STREAMBED    STREAMBED  
   NUMBER   CELLID                  STAGE        DEPTH        WIDTH       GWF HEAD   CONDUCTANCE    GRADIENT  
 -------------------------------------------------------------------------------------------------------------
     1      NONE                     DRY       0.0000       0.0000           --           --           --     
     2      (1,1,1)               7.90536E-02  7.90536E-02  1.0000       1.0000       1.0000      -0.92094    
     3      (1,1,1)               0.18546      0.18546      1.0000       1.0000       1.0000      -0.81454    
     4      (1,1,1)               0.27498      0.27498      1.0000       1.0000       1.0000      -0.72502    
 -------------------------------------------------------------------------------------------------------------

Stress Period 2 with inactive reach 4 and mover from reach 3 to reach 1

SFR-1 PACKAGE - SUMMARY OF FLOWS FOR EACH CONTROL VOLUME   PERIOD      2   STEP        1
 --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
                                                                                                                                                                                               PERCENT   
   NUMBER   CELLID                  INFLOW      OUTFLOW        GWF        RAINFALL   EVAPORATION     RUNOFF     EXT INFLOW  EXT OUTFLOW    STORAGE      FROM MVR      TO MVR      IN - OUT    DIFFERENCE 
 --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
     1      NONE                  0.0000      -2.8145       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       2.8145       0.0000       0.0000       0.0000     
     2      (1,1,1)               2.8145       0.0000       0.74757      0.0000       0.0000       0.0000       0.0000      -3.5621       0.0000       0.0000       0.0000       0.0000       0.0000     
     3      (1,1,1)               0.0000       0.0000       0.81454      1.0000      -1.0000       1.0000       1.0000      -1.68460E-07  0.0000       0.0000      -2.8145       0.0000       0.0000     
     4      (1,1,1)               0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000     
 --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

SFR PACKAGE (SFR-1) STAGES FOR EACH CONTROL VOLUME   PERIOD      2   STEP        1
 -------------------------------------------------------------------------------------------------------------
                                                                                      STREAMBED    STREAMBED  
   NUMBER   CELLID                  STAGE        DEPTH        WIDTH       GWF HEAD   CONDUCTANCE    GRADIENT  
 -------------------------------------------------------------------------------------------------------------
     1      NONE                  0.23423      0.23423      1.0000           --           --           --     
     2      (1,1,1)               0.25243      0.25243      1.0000       1.0000       1.0000      -0.74757    
     3      (1,1,1)               0.18546      0.18546      1.0000       1.0000       1.0000      -0.81454    
     4      (1,1,1)                INACTIVE     INACTIVE     INACTIVE    1.0000        INACTIVE     INACTIVE  
 -------------------------------------------------------------------------------------------------------------

@jdhughes-usgs
Copy link
Contributor Author

Final updates on the tables

Stress period 1 with dry reach 3

SFR-1 PACKAGE - SUMMARY OF FLOWS FOR EACH CONTROL VOLUME   PERIOD      1   STEP        1
 --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
                                                                                                                                                                                               PERCENT   
   NUMBER   CELLID                  INFLOW      OUTFLOW        GWF        RAINFALL   EVAPORATION     RUNOFF     EXT INFLOW  EXT OUTFLOW    STORAGE      FROM MVR      TO MVR      IN - OUT    DIFFERENCE 
 --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
     1      (1,1,1)               0.0000      -2.8145       0.81454      1.0000      -1.0000       1.0000       1.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000     
     2      (1,1,1)               2.8145       0.0000       0.72502      1.0000      -1.0000       1.0000       0.0000      -4.5396       0.0000       0.0000       0.0000       0.0000       0.0000     
     3      NONE                  0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000     
     4      (1,1,1)               0.0000       0.0000       0.92094      0.0000       0.0000       0.0000       0.0000      -0.92094      0.0000       0.0000       0.0000       0.0000       0.0000     
 --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------



 SFR PACKAGE (SFR-1) STAGES FOR EACH CONTROL VOLUME   PERIOD      1   STEP        1
 -------------------------------------------------------------------------------------------------------------
                                                                                      STREAMBED    STREAMBED  
   NUMBER   CELLID                  STAGE        DEPTH        WIDTH       GWF HEAD   CONDUCTANCE    GRADIENT  
 -------------------------------------------------------------------------------------------------------------
     1      (1,1,1)               0.18546      0.18546      1.0000       1.0000       1.0000      -0.81454    
     2      (1,1,1)               0.27498      0.27498      1.0000       1.0000       1.0000      -0.72502    
     3      NONE                     DRY       0.0000       0.0000           --           --           --     
     4      (1,1,1)               7.90536E-02  7.90536E-02  1.0000       1.0000       1.0000      -0.92094    
 -------------------------------------------------------------------------------------------------------------

Stress Period 2 with inactive reach 2 and mover from reach 1 to reach 4

SFR-1 PACKAGE - SUMMARY OF FLOWS FOR EACH CONTROL VOLUME   PERIOD      2   STEP        1
 --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
                                                                                                                                                                                               PERCENT   
   NUMBER   CELLID                  INFLOW      OUTFLOW        GWF        RAINFALL   EVAPORATION     RUNOFF     EXT INFLOW  EXT OUTFLOW    STORAGE      FROM MVR      TO MVR      IN - OUT    DIFFERENCE 
 --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
     1      (1,1,1)               0.0000       0.0000       0.81454      1.0000      -1.0000       1.0000       1.0000      -1.68460E-07  0.0000       0.0000      -2.8145       0.0000       0.0000     
     2      (1,1,1)               0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000     
     3      NONE                  0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000       0.0000     
     4      (1,1,1)               0.0000       0.0000       0.74757      0.0000       0.0000       0.0000       0.0000      -3.5621       0.0000       2.8145       0.0000       0.0000       0.0000     
 --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


SFR PACKAGE (SFR-1) STAGES FOR EACH CONTROL VOLUME   PERIOD      2   STEP        1
 -------------------------------------------------------------------------------------------------------------
                                                                                      STREAMBED    STREAMBED  
   NUMBER   CELLID                  STAGE        DEPTH        WIDTH       GWF HEAD   CONDUCTANCE    GRADIENT  
 -------------------------------------------------------------------------------------------------------------
     1      (1,1,1)               0.18546      0.18546      1.0000       1.0000       1.0000      -0.81454    
     2      (1,1,1)                INACTIVE     INACTIVE     INACTIVE    1.0000        INACTIVE     INACTIVE  
     3      NONE                     DRY       0.0000       0.0000           --           --           --     
     4      (1,1,1)               0.25243      0.25243      1.0000       1.0000       1.0000      -0.74757    
 -------------------------------------------------------------------------------------------------------------

@jdhughes-usgs jdhughes-usgs marked this pull request as ready for review April 18, 2024 13:53
Copy link
Contributor

@langevin-usgs langevin-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jdhughes-usgs jdhughes-usgs merged commit 91034f6 into MODFLOW-USGS:develop Apr 18, 2024
17 checks passed
@jdhughes-usgs jdhughes-usgs deleted the sfr-inactive branch April 18, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants