Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ArrayHandlers): add 2D array expansion interface #1382

Merged
merged 1 commit into from
Oct 6, 2023
Merged

feat(ArrayHandlers): add 2D array expansion interface #1382

merged 1 commit into from
Oct 6, 2023

Conversation

wpbonelli
Copy link
Contributor

@wpbonelli wpbonelli commented Oct 2, 2023 •
edited
Loading

Support expanding 2D integer & double allocatable arrays. For use by PRT for particle bookkeeping.

unit testing demo/discussion moved to #1387

@wpbonelli wpbonelli marked this pull request as ready for review October 2, 2023 19:01
langevin-usgs
langevin-usgs reviewed Oct 3, 2023
View reviewed changes
Copy link
Contributor

@langevin-usgs langevin-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to array handlers looks good. I think we should probably have a discussion about the use of test-drive and make sure this is the direction we want to head. It looks promising.

@wpbonelli wpbonelli mentioned this pull request Oct 5, 2023
Closed
@wpbonelli wpbonelli merged commit 2177e8d into MODFLOW-USGS:develop Oct 6, 2023
48 checks passed
@wpbonelli wpbonelli deleted the expand2d branch October 6, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langevin-usgs langevin-usgs langevin-usgs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wpbonelli @langevin-usgs