Release 6.4.2 #1279
Merged
Release 6.4.2 #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reinitialize develop branch
* skip developmode tests on master CI * fix distribution folder name in docs * only build docs in build_dist.py for full release
* skip develop mode tests on master CI * remind to merge not squash in release PR * only build docs in build_dist.py for full release * fix trailing '_' in distribution folder name in docs
* initialize for v6.5.0 * reorganize appendix A
* add latest release badge * remove badge for removed nightly build workflow * mention code.json in Nightly Builds section * expand explanation of branching/releases
#1115) * fix(typo): patch-up for relatively inconsequential typo * one more * another
* fix(sft): clean-up some minor typos in SFT * comment cleanup
* - split model budget routines in Exchange for parallel dev - allocate NPF angle arrays at 0 size when not present * - fprettify * - suppressoutput uninitialized... (it was always 0) * - fix: reverse nodes for bd w.r.t. model2 * - fprettify * - collateral from refactoring... * arghh, one more...
* - refactored ia,ja,amat into new matrix type for all packages, models, exchanges
…rmatting (#1125) * refactor(idm): run black formatting on dfn2f90.py * refactor(idm): variables default to required in input definitions; formatting Co-authored-by: mjreno <[email protected]>
* fix(MemoryManager): set MemoryType reallocated array pointer in reallocate_charstr1d * fix(MemoryManager): fixes * set MemoryType reallocated array pointer in reallocate_charstr1d * get_isize should return -1 when variable not found Co-authored-by: mjreno <[email protected]>
Co-authored-by: mjreno <[email protected]>
…context (#1126) * match input definition param on blockname as well as component/subcomponent type * do not rely on fortran short-circuit behavior when evaluating compound logical expressions * refactor(idm): rework loading of filein/fileout record tags to input context Co-authored-by: mjreno <[email protected]>
…#1127) * consolidate idm input_load calls upward into the model context * run build_makefiles.py * clean-up * place package input load in appropriate model scope * update pymake Co-authored-by: mjreno <[email protected]>
* use fixtures from devtools for loading external models and tracking target exes * convert adhoc --model, --package and --original-regression opts to pytest fixtures/CLI opts * use devtools and flopy in build_exes.py and get_exes.py, remove pymake usage * remove pymake usage from common_regression.py and external model tests * use GitHub API token for CI step to download executables * update developer docs
* add pytest as a ReadTheDocs dependency * update DEVELOPER.md (TOC, minor fixes) * don't install modflow6-examples for commit-triggered CI * explicitly deselect large/example model tests in commit-triggered CI * fix conftest.should_compare()
* use myst-parser (and remove recommonmark) * add modflow-devtools as rtd dependency * use update_version fn directly in conf.py * add explanatory comment to docs.yml * update copyright year from 2020 to 2023
* refactor(tests): refactor test framework * use keepable temporary dirs instead of manually managed temp folder * use pytest-order and add optional --path arg to update_flopy.py CLI * remove binary_file_writer.py, disu_util.py, budget_file_compare.py * rename Simulation -> TestSimulation and Framework -> TestFramework * partially refactor gwf test scripts with pytest-cases * remove mfpymake as a testing dependency * chore(tests): remove print statements referencing pymake * chore(tests): add large model test marker to pytest.ini * fix(tests): use keepable tmpdirs in pytest-cases POC
Add autotest for fix (test_gwf_pertim.py) and run black on autotest subdirectory.
* close #851 * add new chapter to Supplemental Technical Information * update release notes * revise and simplify code * change definitions for MST and IST bulk density * final revisions to sorption writeup in tech doc
* Non convergence is no reason to crash the API * fprettify
…sults (#1147) * The ICELLTYPE input variable in the Node Property Flow (NPF) Package behaves differently depending on whether or not the THICKSTRT option is specified by the user. In some cases, the program would give unexpected results if a negative value was specified for ICELLTYPE and the THICKSTRT option was not active. For example, the Horizontal Flow Barrier (HFB) Package did not work property when negative values for ICELLTYPE were specified by the user, but the THICKSTRT option was not activated. The program was modified so that negative ICELLTYPE values provided by the user are automatically reassigned a value of one when the user does not activate the THICKSTRT option. This is the intended behavior and is consistent with the input and output guide. * close #1146
The u9rdcom line reader was introduced to replace the u8rdcom line reader, however, u8rdcom was not removed completely. This PR removes u8rdcom entirely. This simplification may help with ongoing efforts to remove calls to the Fortran backspace intrinsic so that mf6 will compile with latest versions of ifort.
…#1252) * add developmode marker to programmatically defined tests that use dev options * skip modflow6-testmodels with dev in name if markers include not developmode * add modflow-devtools link to readme CI section
* introduce dispatch_release.yml to trigger/orchestrate release * refactor release.yml to only build the release distribution * make release.yml reusable with workflow_call trigger * make release options configurable: version, branch, testing, reset, approval, minimal vs. full build * refactor distribution scripts to support an optional version label * update release procedure guide
* remove default branch input in release.yml * fix check_dist.py test for IDEVELOPMODE
- petsc initialize with backwards compatability
* Refactor meson files to build a CRAY parallel version of MODFLOW using cray-mpich (7.7.19) and cray-petsc (3.14.5) * Bumped minimum version of meson to 1.1.0. * Updated `PARALLEL.md` with information on installing OpenMPI and PETSc on MacOS using Homebrew. * Added license for PETSc (this is only added to the license when MODFLOW is built with PETSc) * Added functionality to use MODFLOW 6 PROFESSIONAL in the header written to the screen and listing files when MODFLOW 6 is built with PETSC * Added minimal MODFLOW simulation files in `.mf6minsim` directory that can be used for testing serial and parallel builds * Update makefiles
* refactor release.yml inputs: developmode, approve, full * use full: true in release_dispatch.yml * corresponding updates to distribution scripts * remove path fix for ifort/mamba in workflows * update release docs
…nmnames input string (#1260) Co-authored-by: mjreno <[email protected]>
* update release_dispatch.yml input descriptions * fix sample output substituted into mf6io * prevent double zipping on Windows * fix steps to build examples * update check_dist.py * format dist scripts
* add information about drain discharge scaling * add warning if ATS used for steady state period * Close #769
* use github token to avoid rate limit * only run one example in check_dist.py * upload zipped versions on all platforms * fix release_dispatch.yml set_options condition
* Use lower case for all error messages * Remove leading spaces from error messages * Remove ***ERROR prefix from error messages * Close #758
…taining AUX variables (#1270) - Added autotest to confirm that binary stress period data with auxiliary data can be run. - Updated the release notes.
* fix(deprecation message): deprecation message changed from 6.5.0 to 6.4.2 * deprecation message referred to wrong version * * correct typos in GWT MST error message * improve release note wording in response to Richard Winston suggestions * Correct several references to 6.5.0 to 6.4.2 * update some version information
* fix input usages in release_dispatch.yml * install triangle/gridgen before ci_build_files.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MODFLOW 6.4.2 release
The release can be approved by merging this PR into
master. Merging rather than squashing is necessary to preserve the commit history.When this PR is merged, a final job will be triggered to:
developfrommaster, resetting version files and settingIDEVELOPMODE=1