Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce DIVFLOW bounds when cprior is type FRACTION #635

Closed
emorway-usgs opened this issue Feb 11, 2021 · 1 comment · Fixed by #636
Closed

Enforce DIVFLOW bounds when cprior is type FRACTION #635

emorway-usgs opened this issue Feb 11, 2021 · 1 comment · Fixed by #636

Comments

@emorway-usgs
Copy link
Contributor

Need error check in SFR that enforces the bounds documented in mf6io.pdf (see screen shot below) when cprior = FRACTION for a diversion. For example, if a user inadvertently sets divflow in the PERIOD block to something greater than 1.0 when cprior type is FRACTION, MF6 will create water and keep computing, leading to misleading results. Further, no issue shows up in the budget table because everything will balance by the created water.

up_bound
@emorway-usgs emorway-usgs mentioned this issue Feb 11, 2021
Merged
@emorway-usgs
Copy link
Contributor Author

Evidence that the new test was in fact executed and passed:
new_test

verkaik pushed a commit to verkaik/modflow6-parallel that referenced this issue Mar 15, 2021
@langevin-usgs
feat(transport): update develop with some general routines needed for…
ff705ce 
… transport (MODFLOW-USGS#339)

* feat(transport): update develop with some general routines needed for transport
* fix(mover): correct typo in error message
* closes MODFLOW-USGS#336
* refactor(disu): correct type in disu error message
* closes MODFLOW-USGS#635
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(sfr): enforce divflow<=1.0 for divs with cprior type 'FRACTION'
1 participant
@emorway-usgs