Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: explicitly checkout develop branch of modflow6, simplify steps #20

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

wpbonelli
Copy link
Contributor

@wpbonelli wpbonelli commented Oct 25, 2022

  • bump actions/checkout to v3
  • use actions/checkout option ref: develop
    • the action's default behavior is to checkout the default branch — this makes sure MODFLOW 6 repo's develop branch is used for the nightly build even if the default branch changes (e.g., to master)
  • use pwsh for ifort build on Windows (makes system path adjustment for MSVC unnecessary)

@wpbonelli wpbonelli marked this pull request as ready for review October 25, 2022 15:48
@wpbonelli wpbonelli marked this pull request as draft October 28, 2022 08:29
@wpbonelli wpbonelli marked this pull request as ready for review October 31, 2022 17:34
@wpbonelli wpbonelli marked this pull request as draft October 31, 2022 17:35
@wpbonelli wpbonelli marked this pull request as ready for review November 3, 2022 21:55
@wpbonelli wpbonelli marked this pull request as draft November 3, 2022 22:39
* bump actions/checkout to v3
* explicitly checkout modflow6 develop branch
* run build_nightly.py with shell: pwsh on Windows
@wpbonelli
Copy link
Contributor Author

This PR previously pinned the flopy dependency to avoid breaking the build if issues make it past that repo's CI, but this change has been removed following discussion with @langevin-usgs and @jdhughes-usgs — given the tight coupling between modflow6 and flopy, we want the nightly build to expose integration issues at the bleeding edge.

@wpbonelli wpbonelli marked this pull request as ready for review November 3, 2022 22:47
@langevin-usgs langevin-usgs merged commit 66c7c83 into MODFLOW-USGS:master Nov 8, 2022
@wpbonelli wpbonelli deleted the ci branch November 8, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants