Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use fortran cache/install actions #19

Merged
merged 3 commits into from
Sep 19, 2022

Conversation

wpbonelli
Copy link
Contributor

@wpbonelli wpbonelli commented Sep 1, 2022

Use the new actions to install/cache fortran compilers:

Also remove some duplication of Python requirements between the three previous locations:

  • .github/common/install-python-std.sh
  • etc/requirements.pip.txt
  • etc/requirements.usgs.txt

These are now in a single requirements.txt in the project root

* add reusable github actions cache_ifort and cache_gfortran
* use ifort/gfortran actions in CI workflows
* bump actions/cache to v3
Copy link
Contributor

@jdhughes-usgs jdhughes-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how nicely this condenses the main workflow files

* use modflowpy/install-gfortran-action and install-intelfortran-action
* remove fortran compiler scripts
* consolidate python deps in requirements.txt
@wpbonelli wpbonelli changed the title ci: add fortran cache/install actions ci: use fortran cache/install actions Sep 14, 2022
@wpbonelli wpbonelli marked this pull request as ready for review September 14, 2022 14:46
Copy link
Contributor

@langevin-usgs langevin-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see so much code going away.

@langevin-usgs langevin-usgs merged commit 38d4d06 into MODFLOW-USGS:master Sep 19, 2022
@wpbonelli wpbonelli deleted the ci branch October 18, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants