Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: restore double precision executables #24

Merged
merged 13 commits into from
Feb 15, 2024
Merged

refactor: restore double precision executables #24

merged 13 commits into from
Feb 15, 2024

Conversation

wpbonelli
Copy link
Contributor

@wpbonelli wpbonelli commented Feb 14, 2024 •
edited
Loading

@wpbonelli
refactor: restore double precision executables
133ab07 
* use new --double arg for pymake make-program
* add modflow-devtools to requirements.txt, use ostags module
* use develop branches of pymake and devtools in requirements.txt
@wpbonelli
fix build_executables.py (call make-program twice, once for single pr…
35a5810 
…ec then double)
@wpbonelli
fix error message (single -> default precision)
cfff060
@wpbonelli
various
960c30f 
* don't build cloned version of mf6 for integration testing, use version built by pymake
* rename scripts/build_executables.py -> scripts/build_programs.py
* update .gitignore
@wpbonelli
fix cp step
d83b677
@wpbonelli
lib exts
7506792
@wpbonelli
build mf6 so we have mf5to6
94404f2
@wpbonelli
update flopy
8b6ea86
@wpbonelli
filter tests
c532eb4
@wpbonelli
cleanup, format with black
d03a7e7
@jdhughes-usgs
Copy link
Contributor

@wpbonelli I noticed the upload_excutables step did not find a file to upload in https://github.com/MODFLOW-USGS/executables/pull/24/checks. Looks like the exe's are not being zipped.

@wpbonelli wpbonelli marked this pull request as ready for review February 15, 2024 19:26
@wpbonelli
Copy link
Contributor Author

thanks @jdhughes-usgs

@wpbonelli wpbonelli merged commit e84ff4a into MODFLOW-USGS:master Feb 15, 2024
3 checks passed
@wpbonelli wpbonelli deleted the ci branch February 15, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdhughes-usgs jdhughes-usgs jdhughes-usgs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wpbonelli @jdhughes-usgs