Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atlas: 生成されたatlasの未使用ピクセル数(RGBA→0,0,0,0)を取得するexamplesの実装 #605

Conversation

yud0uhu
Copy link

@yud0uhu yud0uhu commented Jul 20, 2024

Close #600

Description(変更内容)

  • atlas: テクスチャアトラス化手法の調査 #582 にて調査したアルゴリズムを実装するために、アルゴリズム間の比較を行うための前準備として、最適化度を計測する指標(atlasの未使用ピクセル数を取得する)のexamplesを追加しました。

Manual Testing(手動テスト)

プロジェクトのディレクトリ直下で以下のコマンドを実行すると、挙動が確認できます。

git checkout feature/examples-texture-atlas-unused-pixels
cd nusamai-atlas
cargo run -- -u examples/output/0.png
# cargo run -- -unused_pixels examples/output/0.png

出力結果

PlacedTextureInfo { id: "texture_yellow_dice_0", atlas_id: "0", origin: (1, 1), width: 80, height: 48, placed_uv_coords: [(0.158203125, 0.998046875), (0.001953125, 0.904296875), (0.158203125, 0.904296875)] }
PlacedTextureInfo { id: "texture_yellow_dice_1", atlas_id: "0", origin: (82, 1), width: 80, height: 47, placed_uv_coords: [(0.16015625, 0.998046875), (0.31640625, 0.90625), (0.31640625, 0.998046875)] }
PlacedTextureInfo { id: "texture_yellow_dice_2", atlas_id: "0", origin: (1, 50), width: 80, height: 48, placed_uv_coords: [(0.001953125, 0.90234375), (0.158203125, 0.80859375), (0.158203125, 0.90234375)] }
// ...
Unused pixels: 231195

@yud0uhu yud0uhu self-assigned this Jul 20, 2024
Copy link

coderabbitai bot commented Jul 20, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files
Components Coverage Δ
GUI ∅ <ø> (∅)
Backend 82.03% <ø> (ø)
Libraries 83.20% <ø> (ø)

📢 Thoughts on this report? Let us know!

@yud0uhu yud0uhu force-pushed the feature/examples-texture-atlas-unused-pixels branch from c3589b6 to f681bcb Compare July 22, 2024 00:27
@yud0uhu yud0uhu marked this pull request as ready for review August 6, 2024 00:50
@nokonoko1203 nokonoko1203 self-requested a review August 7, 2024 05:40
@nokonoko1203 nokonoko1203 marked this pull request as draft August 8, 2024 03:55
@nokonoko1203 nokonoko1203 removed their request for review August 8, 2024 06:45
@nokonoko1203 nokonoko1203 deleted the branch feature/texture-atlas August 9, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants