Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had the same problem as mentioned here. According to NumPy 1.20.0 Release Notes, changing np.float to float should work.
I think it is better to change every occurrence of np.float (and also np.int, np.bool and np.object, because they are also deprecated) in the package, not only mesh_elements.py, because it will cause problems in the other places as well. I went through all the occurrences and tried to do the changes.
I was not sure about some decisions base.py. In this file,
np.float
is always used as dtype innp.loadtxt
function. It is not necessary to specifydtype=float
in this function because it is the default option (https://numpy.org/doc/stable/reference/generated/numpy.loadtxt.html), but it might be useful for readability, so I changednp.float
tofloat
everywhere in this file. There are also occurrences ofnp.loadtxt
function withdtype='str'
. I did not want to mix two types of dtype settings (string and python type) and this is the only place using string, so I changeddtype='str'
todtype=str
.