Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Match BokehJS with BokehPy version #703

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Conversation

notZaki
Copy link
Contributor

@notZaki notZaki commented Mar 16, 2021

Closes none.

Context: There are two bokeh libraries: one is in python, the other in javascript. Ideally, they should both be the same version. Currently, the javascript version is pinned at 2.0.1 in the html report. This can create a conflict if the user has a different python version of bokeh.

Changes proposed in this pull request:

  • Dynamically set the javascript version of bokeh to match the python version

@notZaki notZaki changed the title Match BokehJS with BokehPy version [ENH] Match BokehJS with BokehPy version Mar 16, 2021
@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #703 (f13030c) into main (956e01d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #703   +/-   ##
=======================================
  Coverage   93.64%   93.64%           
=======================================
  Files          26       26           
  Lines        2029     2030    +1     
=======================================
+ Hits         1900     1901    +1     
  Misses        129      129           
Impacted Files Coverage Δ
tedana/reporting/html_report.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 956e01d...f13030c. Read the comment docs.

Copy link
Collaborator

@jbteves jbteves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @notZaki !

@jbteves jbteves merged commit 27a1327 into ME-ICA:main Mar 17, 2021
@notZaki notZaki deleted the bokehversion branch March 19, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants