Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move NDEBUG from mdsconfig.h to CFLAGS #2553

Open
wants to merge 1 commit into
base: alpha
Choose a base branch
from
Open

Move NDEBUG from mdsconfig.h to CFLAGS #2553

wants to merge 1 commit into from
+10 −5

Conversation

WhoBrokeTheBuild
Copy link
Contributor

Hopefully fixes #2530

This removes NDEBUG from mdsconfig.h.in by removing the m4_define calls, and instead adds -DNDEBUG to CFLAGS/CXXFLAGS/FCFLAGS

@WhoBrokeTheBuild WhoBrokeTheBuild added bug An unexpected problem or unintended behavior build Relates to the build system refactor Relates to refactoring or code quality improvements core Relates to the core libraries and scripts labels Mar 29, 2023
@WhoBrokeTheBuild WhoBrokeTheBuild self-assigned this Mar 29, 2023
@WhoBrokeTheBuild
Copy link
Contributor Author

Retest this please

1 similar comment
@WhoBrokeTheBuild
Copy link
Contributor Author

Retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zack-vii zack-vii Awaiting requested review from zack-vii

@joshStillerman joshStillerman Awaiting requested review from joshStillerman

At least 1 approving review is required to merge this pull request.

Assignees

@WhoBrokeTheBuild WhoBrokeTheBuild

Labels
bug An unexpected problem or unintended behavior build Relates to the build system core Relates to the core libraries and scripts refactor Relates to refactoring or code quality improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NDEBUG defined when including <mdsobjects.h>
1 participant
@WhoBrokeTheBuild