Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix additional_footer_text setting (#2445) #2444

Merged
merged 1 commit into from
May 25, 2024
Merged

Fix additional_footer_text setting (#2445) #2444

merged 1 commit into from
May 25, 2024

Conversation

leso-kn
Copy link
Contributor

@leso-kn leso-kn commented May 25, 2024 •
edited
Loading

This PR addresses #2445 and fixes the page footer contents when using the additional_footer_text-setting.

Tested on Lychee v5.3.0.

@leso-kn leso-kn changed the title Fix additional_footer_text setting (#2443) Fix additional_footer_text setting (#2445) May 25, 2024
@leso-kn leso-kn force-pushed the fix-additional-footer-text branch from 6d346a9 to 910c441 Compare May 25, 2024 16:07
@ildyria
Copy link
Member

ildyria commented May 25, 2024

Good spot! Thank you. :)

@codecov Codecov
Copy link

codecov bot commented May 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.29%. Comparing base (02e5a20) to head (910c441).
Report is 60 commits behind head on master.

Additional details and impacted files

@ildyria ildyria merged commit 0e1f7f8 into LycheeOrg:master May 25, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ildyria ildyria ildyria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leso-kn @ildyria