Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix share button always visible #2346

Merged
merged 4 commits into from
Apr 6, 2024
Merged

Fix share button always visible #2346

merged 4 commits into from
Apr 6, 2024

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Apr 5, 2024

Fixes #2345

@ildyria ildyria requested a review from a team April 5, 2024 13:27
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Apr 5, 2024
@ildyria ildyria added this to the 5.2.0 milestone Apr 5, 2024
d7415
d7415 approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@d7415 d7415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested.

I'm surprised there was still whitespace that needed fixing!

@ildyria
Copy link
Member Author

ildyria commented Apr 6, 2024

I'm surprised there was still whitespace that needed fixing!

That is because I was using a newer version of php-cs which is included in #2338

@ildyria ildyria merged commit d0fee60 into master Apr 6, 2024
31 checks passed
@ildyria ildyria deleted the fix-share-button-always-visible branch April 6, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7415 d7415 d7415 approved these changes

Assignees
No one assigned
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.

Share Button does not get disabled using share_button_visible 1/0
2 participants
@ildyria @d7415