Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pinning dependencies + fix permissions #2325

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Pinning dependencies + fix permissions #2325

merged 1 commit into from
Mar 21, 2024

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Mar 20, 2024

No description provided.

@ildyria ildyria requested a review from d7415 March 20, 2024 20:56
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Mar 20, 2024
d7415
d7415 approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@d7415 d7415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinning to exact hashes seems like more admin, and probably means we should subscribe to their releases, but if you want to, sure.

@ildyria
Copy link
Member Author

ildyria commented Mar 21, 2024

Pinning to exact hashes seems like more admin, and probably means we should subscribe to their releases, but if you want to, sure.

It is more to fix one of the OSSF finding.
whether you pin the version of the hash is pretty much the same.

@ildyria ildyria merged commit bc63df2 into master Mar 21, 2024
31 checks passed
@ildyria ildyria deleted the fix-scorecard-findings branch March 21, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7415 d7415 d7415 approved these changes

Assignees
No one assigned
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ildyria @d7415