Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null coalescence on css/js to catch when file does not exists. #2256

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Null coalescence on css/js to catch when file does not exists. #2256

merged 1 commit into from
Jan 29, 2024

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jan 28, 2024 •
edited
Loading

Fixes #2255

@ildyria ildyria added Livewire Only Changes that impact Livewire front-end only Review: easy Easy review expected: probably just need a quick to go through. labels Jan 28, 2024
@ildyria ildyria added this to the 5.2.0 milestone Jan 28, 2024
@ildyria ildyria requested a review from a team January 28, 2024 10:21
@codecov Codecov
Copy link

codecov bot commented Jan 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f71f756) 86.09% compared to head (24d8374) 85.90%.

Additional details and impacted files

@ildyria ildyria self-assigned this Jan 28, 2024
@ildyria ildyria changed the title Add null coalescence on css and js to catch when file does not exists. Null coalescence on css/js to catch when file does not exists. Jan 29, 2024
@ildyria ildyria merged commit c559b8a into master Jan 29, 2024
33 checks passed
@ildyria ildyria deleted the avoid-null-when-file-do-not-exists branch January 29, 2024 09:42
@ildyria ildyria mentioned this pull request Jan 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamil4 kamil4 kamil4 approved these changes

Assignees

@ildyria ildyria

Labels
Livewire Only Changes that impact Livewire front-end only Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.

Cannot assign null to property App\Livewire\Components\Pages\Settings::$css of type string
2 participants
@ildyria @kamil4