Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove is_public & deprecated Public smart album #2221

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Remove is_public & deprecated Public smart album #2221

merged 2 commits into from
Jan 25, 2024

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jan 20, 2024

No description provided.

@codecov Codecov
Copy link

codecov bot commented Jan 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7ce7efd) 86.21% compared to head (541fee2) 85.96%.

❗ Current head 541fee2 differs from pull request most recent head 4a5a5c5. Consider uploading reports for the commit 4a5a5c5 to get more accurate results

Additional details and impacted files

@ildyria ildyria force-pushed the remove-public-on-photo branch 2 times, most recently from ff91914 to 64cb18c Compare January 20, 2024 23:18
@ildyria ildyria added the Review: hard Difficult review expected: major changes, lots of files modified, and dependencies updated. label Jan 20, 2024
@ildyria ildyria added this to the 5.2.0 milestone Jan 21, 2024
@ildyria ildyria linked an issue Jan 21, 2024 that may be closed by this pull request
Remove deadcode (is_public on photos & public smart album) #2224
Closed
@ildyria ildyria marked this pull request as ready for review January 21, 2024 12:48
@ildyria ildyria requested a review from a team January 21, 2024 12:48
kamil4
kamil4 approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@kamil4 kamil4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (not tested).

What does it do to the old front end? I see an exception being thrown in routes... Will things continue to work so long as the feature is not used?

@ildyria
Copy link
Member Author

ildyria commented Jan 22, 2024

LGTM (not tested).

What does it do to the old front end? I see an exception being thrown in routes... Will things continue to work so long as the feature is not used?

the public album disappear.
the set public slider on the visibility panel of pictures will throw the aforementioned exception (with the error message visible in the bar).

@ildyria ildyria merged commit 81615bf into master Jan 25, 2024
10 checks passed
@ildyria ildyria deleted the remove-public-on-photo branch January 25, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamil4 kamil4 kamil4 approved these changes

Assignees
No one assigned
Labels
Review: hard Difficult review expected: major changes, lots of files modified, and dependencies updated.
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.

Remove deadcode (is_public on photos & public smart album)
2 participants
@ildyria @kamil4