Skip to content
This repository has been archived by the owner on May 3, 2021. It is now read-only.

Slightly improve lens info by using LensSpec tag instead of Lens tag #235

Closed
wants to merge 3 commits into from

Conversation

mir07
Copy link
Contributor

@mir07 mir07 commented Mar 26, 2019

Fixes #234

Signed-off-by: Michael Rasmussen [email protected]

Copy link
Contributor

@d7415 d7415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there's already a hierarchy here, I'd just add any new tags to the list rather than replacing them. I'm not sure how likely it is for exiftool to return Lens but not LensSpec but if it's possible we should account for it. This would also allow us to include LensID in the list, as requested.

LensID isn't an official EXIF tag, but looks like it's a combination of others so I guess it's probably ok (as we're officially supporting exiftool anyway)

@d7415
Copy link
Contributor

d7415 commented Mar 26, 2019

(I've added a reference to the issue in the description above so that it can be automatically closed on merge)

@mir07
Copy link
Contributor Author

mir07 commented Mar 26, 2019

I have come to the same conclusion so I will prepare a patch to handle all possible lens info tags ordering from best to worst so:

  1. LensID
  2. LensSpec
  3. Lens

@ildyria
Copy link
Member

ildyria commented Mar 26, 2019

Also if such thing can also be added to Lychee-Laravel that would be nice. https://github.com/LycheeOrg/Lychee-laravel

@mir07
Copy link
Contributor Author

mir07 commented Mar 26, 2019

I know but I have never been able to have a functioning Lychee-Laravel installation even when following the instructions to the letter. Without a functioning Lychee-Laravel installation providing patches is impossible.

@d7415 d7415 closed this in 26234e3 Mar 26, 2019
@mir07 mir07 deleted the improve-lens-info branch March 26, 2019 21:32
@d7415
Copy link
Contributor

d7415 commented Mar 26, 2019

Thanks @mir07 !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants