Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for DynamicExpressions in [weakdeps] to 0.18, (keep existing compat) #728

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the DynamicExpressions package from 0.16, 0.17 to 0.16, 0.17, 0.18.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@github-actions github-actions bot force-pushed the compathelper/new_version/2024-06-25-01-00-25-473-01653496524 branch from cb5750f to 3b2aaa4 Compare June 25, 2024 01:00
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.01%. Comparing base (a2e113c) to head (f50ef89).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #728      +/-   ##
==========================================
+ Coverage   96.89%   97.01%   +0.11%     
==========================================
  Files          53       53              
  Lines        2708     2710       +2     
==========================================
+ Hits         2624     2629       +5     
+ Misses         84       81       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avik-pal avik-pal closed this Jun 25, 2024
@avik-pal avik-pal reopened this Jun 25, 2024
@avik-pal avik-pal force-pushed the compathelper/new_version/2024-06-25-01-00-25-473-01653496524 branch from 3b2aaa4 to f50ef89 Compare June 25, 2024 06:20
Copy link
Contributor Author

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Results

Benchmark suite Current: f50ef89 Previous: e3436c7 Ratio
Dense(2 => 2)/cpu/reverse/ReverseDiff (compiled)/(2, 128) 3665.5 ns 3887.25 ns 0.94
Dense(2 => 2)/cpu/reverse/Zygote/(2, 128) 7168.5 ns 7208.5 ns 0.99
Dense(2 => 2)/cpu/reverse/Tracker/(2, 128) 20759 ns 21039 ns 0.99
Dense(2 => 2)/cpu/reverse/ReverseDiff/(2, 128) 9824.6 ns 9773.3 ns 1.01
Dense(2 => 2)/cpu/reverse/Flux/(2, 128) 9064.5 ns 8886.333333333334 ns 1.02
Dense(2 => 2)/cpu/reverse/SimpleChains/(2, 128) 4467.125 ns 4526 ns 0.99
Dense(2 => 2)/cpu/reverse/Enzyme/(2, 128) 1157.4571428571428 ns 1159.6402877697842 ns 1.00
Dense(2 => 2)/cpu/forward/NamedTuple/(2, 128) 1174.982608695652 ns 1173.1338582677165 ns 1.00
Dense(2 => 2)/cpu/forward/ComponentArray/(2, 128) 1163.3706293706293 ns 1178 ns 0.99
Dense(2 => 2)/cpu/forward/Flux/(2, 128) 1772.508064516129 ns 1777.6603773584907 ns 1.00
Dense(2 => 2)/cpu/forward/SimpleChains/(2, 128) 180.43557422969187 ns 179.89703808180536 ns 1.00
Dense(20 => 20)/cpu/reverse/ReverseDiff (compiled)/(20, 128) 17262 ns 17362 ns 0.99
Dense(20 => 20)/cpu/reverse/Zygote/(20, 128) 16822 ns 16891 ns 1.00
Dense(20 => 20)/cpu/reverse/Tracker/(20, 128) 37851 ns 37801 ns 1.00
Dense(20 => 20)/cpu/reverse/ReverseDiff/(20, 128) 29395 ns 29385 ns 1.00
Dense(20 => 20)/cpu/reverse/Flux/(20, 128) 19937 ns 20038 ns 0.99
Dense(20 => 20)/cpu/reverse/SimpleChains/(20, 128) 17253 ns 17723 ns 0.97
Dense(20 => 20)/cpu/reverse/Enzyme/(20, 128) 4338.142857142857 ns 4365.285714285715 ns 0.99
Dense(20 => 20)/cpu/forward/NamedTuple/(20, 128) 3876 ns 3903.5 ns 0.99
Dense(20 => 20)/cpu/forward/ComponentArray/(20, 128) 3959.875 ns 3958.625 ns 1.00
Dense(20 => 20)/cpu/forward/Flux/(20, 128) 4976.428571428572 ns 4936.428571428572 ns 1.01
Dense(20 => 20)/cpu/forward/SimpleChains/(20, 128) 1670.1 ns 1678.1 ns 1.00
Conv((3, 3), 3 => 3)/cpu/reverse/ReverseDiff (compiled)/(64, 64, 3, 128) 39342371 ns 47353187 ns 0.83
Conv((3, 3), 3 => 3)/cpu/reverse/Zygote/(64, 64, 3, 128) 57533710 ns 57459121.5 ns 1.00
Conv((3, 3), 3 => 3)/cpu/reverse/Tracker/(64, 64, 3, 128) 69115007 ns 111628278 ns 0.62
Conv((3, 3), 3 => 3)/cpu/reverse/ReverseDiff/(64, 64, 3, 128) 81192760 ns 102147554 ns 0.79
Conv((3, 3), 3 => 3)/cpu/reverse/Flux/(64, 64, 3, 128) 65192553 ns 91879373 ns 0.71
Conv((3, 3), 3 => 3)/cpu/reverse/SimpleChains/(64, 64, 3, 128) 11659132 ns 12024461 ns 0.97
Conv((3, 3), 3 => 3)/cpu/reverse/Enzyme/(64, 64, 3, 128) 17933480 ns 17787996 ns 1.01
Conv((3, 3), 3 => 3)/cpu/forward/NamedTuple/(64, 64, 3, 128) 7029622 ns 7036219 ns 1.00
Conv((3, 3), 3 => 3)/cpu/forward/ComponentArray/(64, 64, 3, 128) 7015867 ns 7002155 ns 1.00
Conv((3, 3), 3 => 3)/cpu/forward/Flux/(64, 64, 3, 128) 9930463 ns 12625823 ns 0.79
Conv((3, 3), 3 => 3)/cpu/forward/SimpleChains/(64, 64, 3, 128) 6399000 ns 6384473 ns 1.00
vgg16/cpu/reverse/Zygote/(32, 32, 3, 16) 746943233 ns 745718885 ns 1.00
vgg16/cpu/reverse/Zygote/(32, 32, 3, 64) 2568463524 ns 2613188414 ns 0.98
vgg16/cpu/reverse/Zygote/(32, 32, 3, 2) 143907344 ns 133541816 ns 1.08
vgg16/cpu/reverse/Tracker/(32, 32, 3, 16) 818959983 ns 978182080 ns 0.84
vgg16/cpu/reverse/Tracker/(32, 32, 3, 64) 2911046958 ns 3291926463 ns 0.88
vgg16/cpu/reverse/Tracker/(32, 32, 3, 2) 205230725 ns 224285101.5 ns 0.92
vgg16/cpu/reverse/Flux/(32, 32, 3, 16) 710299135 ns 721100246.5 ns 0.99
vgg16/cpu/reverse/Flux/(32, 32, 3, 64) 2637406201.5 ns 2850977134 ns 0.93
vgg16/cpu/reverse/Flux/(32, 32, 3, 2) 126879095.5 ns 129262795.5 ns 0.98
vgg16/cpu/forward/NamedTuple/(32, 32, 3, 16) 174452145 ns 174929704.5 ns 1.00
vgg16/cpu/forward/NamedTuple/(32, 32, 3, 64) 645890771.5 ns 655380124.5 ns 0.99
vgg16/cpu/forward/NamedTuple/(32, 32, 3, 2) 34825782 ns 34639543 ns 1.01
vgg16/cpu/forward/ComponentArray/(32, 32, 3, 16) 165591893 ns 164825547 ns 1.00
vgg16/cpu/forward/ComponentArray/(32, 32, 3, 64) 645578010 ns 646891648 ns 1.00
vgg16/cpu/forward/ComponentArray/(32, 32, 3, 2) 30443535 ns 30465993 ns 1.00
vgg16/cpu/forward/Flux/(32, 32, 3, 16) 185853578.5 ns 234268398 ns 0.79
vgg16/cpu/forward/Flux/(32, 32, 3, 64) 739239876.5 ns 904515656 ns 0.82
vgg16/cpu/forward/Flux/(32, 32, 3, 2) 37789014 ns 38648070 ns 0.98
Conv((3, 3), 64 => 64)/cpu/reverse/ReverseDiff (compiled)/(64, 64, 64, 128) 1234760908.5 ns 1247988558 ns 0.99
Conv((3, 3), 64 => 64)/cpu/reverse/Zygote/(64, 64, 64, 128) 1877065833 ns 1867098273 ns 1.01
Conv((3, 3), 64 => 64)/cpu/reverse/Tracker/(64, 64, 64, 128) 2396264428 ns 2446432027 ns 0.98
Conv((3, 3), 64 => 64)/cpu/reverse/ReverseDiff/(64, 64, 64, 128) 2647343592 ns 2590410001 ns 1.02
Conv((3, 3), 64 => 64)/cpu/reverse/Flux/(64, 64, 64, 128) 1855282544 ns 1928343677 ns 0.96
Conv((3, 3), 64 => 64)/cpu/reverse/Enzyme/(64, 64, 64, 128) 591022068 ns 566763452 ns 1.04
Conv((3, 3), 64 => 64)/cpu/forward/NamedTuple/(64, 64, 64, 128) 333040198 ns 319531483 ns 1.04
Conv((3, 3), 64 => 64)/cpu/forward/ComponentArray/(64, 64, 64, 128) 326942244 ns 319551888 ns 1.02
Conv((3, 3), 64 => 64)/cpu/forward/Flux/(64, 64, 64, 128) 358964166 ns 475027346.5 ns 0.76
Conv((3, 3), 1 => 1)/cpu/reverse/ReverseDiff (compiled)/(64, 64, 1, 128) 12029150 ns 11896287 ns 1.01
Conv((3, 3), 1 => 1)/cpu/reverse/Zygote/(64, 64, 1, 128) 17894100 ns 17761806 ns 1.01
Conv((3, 3), 1 => 1)/cpu/reverse/Tracker/(64, 64, 1, 128) 19343484 ns 19186566 ns 1.01
Conv((3, 3), 1 => 1)/cpu/reverse/ReverseDiff/(64, 64, 1, 128) 23948951 ns 23819926 ns 1.01
Conv((3, 3), 1 => 1)/cpu/reverse/Flux/(64, 64, 1, 128) 17967639 ns 17776322.5 ns 1.01
Conv((3, 3), 1 => 1)/cpu/reverse/SimpleChains/(64, 64, 1, 128) 1194593.5 ns 1171203 ns 1.02
Conv((3, 3), 1 => 1)/cpu/reverse/Enzyme/(64, 64, 1, 128) 5927290 ns 5814455 ns 1.02
Conv((3, 3), 1 => 1)/cpu/forward/NamedTuple/(64, 64, 1, 128) 2063352.5 ns 2051853.5 ns 1.01
Conv((3, 3), 1 => 1)/cpu/forward/ComponentArray/(64, 64, 1, 128) 2051906 ns 2031131.5 ns 1.01
Conv((3, 3), 1 => 1)/cpu/forward/Flux/(64, 64, 1, 128) 2089160.5 ns 2083988 ns 1.00
Conv((3, 3), 1 => 1)/cpu/forward/SimpleChains/(64, 64, 1, 128) 213771 ns 199531.5 ns 1.07
Dense(200 => 200)/cpu/reverse/ReverseDiff (compiled)/(200, 128) 297167 ns 296482 ns 1.00
Dense(200 => 200)/cpu/reverse/Zygote/(200, 128) 267862 ns 270294 ns 0.99
Dense(200 => 200)/cpu/reverse/Tracker/(200, 128) 372208 ns 376601 ns 0.99
Dense(200 => 200)/cpu/reverse/ReverseDiff/(200, 128) 413009 ns 414613 ns 1.00
Dense(200 => 200)/cpu/reverse/Flux/(200, 128) 277745.5 ns 278469 ns 1.00
Dense(200 => 200)/cpu/reverse/SimpleChains/(200, 128) 410179 ns 414752 ns 0.99
Dense(200 => 200)/cpu/reverse/Enzyme/(200, 128) 83727 ns 84007 ns 1.00
Dense(200 => 200)/cpu/forward/NamedTuple/(200, 128) 81914 ns 82724 ns 0.99
Dense(200 => 200)/cpu/forward/ComponentArray/(200, 128) 82404 ns 83055 ns 0.99
Dense(200 => 200)/cpu/forward/Flux/(200, 128) 87343 ns 88064 ns 0.99
Dense(200 => 200)/cpu/forward/SimpleChains/(200, 128) 104797 ns 104605 ns 1.00
Conv((3, 3), 16 => 16)/cpu/reverse/ReverseDiff (compiled)/(64, 64, 16, 128) 194021975 ns 203091458 ns 0.96
Conv((3, 3), 16 => 16)/cpu/reverse/Zygote/(64, 64, 16, 128) 321965126 ns 324083308.5 ns 0.99
Conv((3, 3), 16 => 16)/cpu/reverse/Tracker/(64, 64, 16, 128) 364294777 ns 444446262 ns 0.82
Conv((3, 3), 16 => 16)/cpu/reverse/ReverseDiff/(64, 64, 16, 128) 456804432.5 ns 479663115 ns 0.95
Conv((3, 3), 16 => 16)/cpu/reverse/Flux/(64, 64, 16, 128) 372791301 ns 425565719.5 ns 0.88
Conv((3, 3), 16 => 16)/cpu/reverse/SimpleChains/(64, 64, 16, 128) 330053861 ns 350066677 ns 0.94
Conv((3, 3), 16 => 16)/cpu/reverse/Enzyme/(64, 64, 16, 128) 102013337 ns 101339114 ns 1.01
Conv((3, 3), 16 => 16)/cpu/forward/NamedTuple/(64, 64, 16, 128) 43785109 ns 44189193.5 ns 0.99
Conv((3, 3), 16 => 16)/cpu/forward/ComponentArray/(64, 64, 16, 128) 43631551.5 ns 43907554 ns 0.99
Conv((3, 3), 16 => 16)/cpu/forward/Flux/(64, 64, 16, 128) 59364704.5 ns 58998085 ns 1.01
Conv((3, 3), 16 => 16)/cpu/forward/SimpleChains/(64, 64, 16, 128) 28170614 ns 28426865 ns 0.99
Dense(2000 => 2000)/cpu/reverse/ReverseDiff (compiled)/(2000, 128) 19056907 ns 19441532 ns 0.98
Dense(2000 => 2000)/cpu/reverse/Zygote/(2000, 128) 19573099 ns 19775347 ns 0.99
Dense(2000 => 2000)/cpu/reverse/Tracker/(2000, 128) 23365125 ns 23883247.5 ns 0.98
Dense(2000 => 2000)/cpu/reverse/ReverseDiff/(2000, 128) 24125435 ns 24407540 ns 0.99
Dense(2000 => 2000)/cpu/reverse/Flux/(2000, 128) 19721721 ns 19869867 ns 0.99
Dense(2000 => 2000)/cpu/reverse/Enzyme/(2000, 128) 6527266 ns 6557191 ns 1.00
Dense(2000 => 2000)/cpu/forward/NamedTuple/(2000, 128) 6533729.5 ns 6582396 ns 0.99
Dense(2000 => 2000)/cpu/forward/ComponentArray/(2000, 128) 6526452 ns 6551248 ns 1.00
Dense(2000 => 2000)/cpu/forward/Flux/(2000, 128) 6491936 ns 6557028 ns 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@avik-pal avik-pal merged commit 39cf6ca into main Jun 25, 2024
50 of 53 checks passed
@avik-pal avik-pal deleted the compathelper/new_version/2024-06-25-01-00-25-473-01653496524 branch June 25, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant