-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatHelper: bump compat for AMDGPU in [weakdeps] to 0.9, (keep existing compat) #717
CompatHelper: bump compat for AMDGPU in [weakdeps] to 0.9, (keep existing compat) #717
Conversation
34185da
to
8db7d2f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #717 +/- ##
===========================================
+ Coverage 77.91% 96.51% +18.60%
===========================================
Files 54 54
Lines 2726 2728 +2
===========================================
+ Hits 2124 2633 +509
+ Misses 602 95 -507 ☔ View full report in Codecov by Sentry. |
8db7d2f
to
74cffe1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark Results
Benchmark suite | Current: 27e3deb | Previous: 855935a | Ratio |
---|---|---|---|
Dense(2 => 2)/cpu/reverse/ReverseDiff (compiled)/(2, 128) |
3634.375 ns |
3695.5 ns |
0.98 |
Dense(2 => 2)/cpu/reverse/Zygote/(2, 128) |
7236.833333333333 ns |
7170 ns |
1.01 |
Dense(2 => 2)/cpu/reverse/Tracker/(2, 128) |
21234.5 ns |
20418 ns |
1.04 |
Dense(2 => 2)/cpu/reverse/ReverseDiff/(2, 128) |
9753.1 ns |
9770.2 ns |
1.00 |
Dense(2 => 2)/cpu/reverse/Flux/(2, 128) |
9075.625 ns |
8956.5 ns |
1.01 |
Dense(2 => 2)/cpu/reverse/SimpleChains/(2, 128) |
4503.375 ns |
4479.625 ns |
1.01 |
Dense(2 => 2)/cpu/reverse/Enzyme/(2, 128) |
1160.2605633802816 ns |
1154.9305555555557 ns |
1.00 |
Dense(2 => 2)/cpu/forward/NamedTuple/(2, 128) |
1171.8702290076335 ns |
1168.8444444444444 ns |
1.00 |
Dense(2 => 2)/cpu/forward/ComponentArray/(2, 128) |
1173.0283687943263 ns |
1180.4338235294117 ns |
0.99 |
Dense(2 => 2)/cpu/forward/Flux/(2, 128) |
1786.2033898305085 ns |
1801.1020408163265 ns |
0.99 |
Dense(2 => 2)/cpu/forward/SimpleChains/(2, 128) |
179.36022253129346 ns |
180.1682892906815 ns |
1.00 |
Dense(20 => 20)/cpu/reverse/ReverseDiff (compiled)/(20, 128) |
17252 ns |
17283 ns |
1.00 |
Dense(20 => 20)/cpu/reverse/Zygote/(20, 128) |
17012 ns |
16792 ns |
1.01 |
Dense(20 => 20)/cpu/reverse/Tracker/(20, 128) |
37890 ns |
38251 ns |
0.99 |
Dense(20 => 20)/cpu/reverse/ReverseDiff/(20, 128) |
29074 ns |
29075 ns |
1.00 |
Dense(20 => 20)/cpu/reverse/Flux/(20, 128) |
21540 ns |
21370 ns |
1.01 |
Dense(20 => 20)/cpu/reverse/SimpleChains/(20, 128) |
17242 ns |
17182 ns |
1.00 |
Dense(20 => 20)/cpu/reverse/Enzyme/(20, 128) |
4382.428571428572 ns |
4269.428571428572 ns |
1.03 |
Dense(20 => 20)/cpu/forward/NamedTuple/(20, 128) |
3891 ns |
3810.75 ns |
1.02 |
Dense(20 => 20)/cpu/forward/ComponentArray/(20, 128) |
3973.75 ns |
3916 ns |
1.01 |
Dense(20 => 20)/cpu/forward/Flux/(20, 128) |
4957.071428571428 ns |
4863.285714285715 ns |
1.02 |
Dense(20 => 20)/cpu/forward/SimpleChains/(20, 128) |
1651 ns |
1666.1 ns |
0.99 |
Conv((3, 3), 3 => 3)/cpu/reverse/ReverseDiff (compiled)/(64, 64, 3, 128) |
48793475 ns |
39819177.5 ns |
1.23 |
Conv((3, 3), 3 => 3)/cpu/reverse/Zygote/(64, 64, 3, 128) |
57399593.5 ns |
57557818.5 ns |
1.00 |
Conv((3, 3), 3 => 3)/cpu/reverse/Tracker/(64, 64, 3, 128) |
111003547 ns |
80831864 ns |
1.37 |
Conv((3, 3), 3 => 3)/cpu/reverse/ReverseDiff/(64, 64, 3, 128) |
103464572.5 ns |
91221464 ns |
1.13 |
Conv((3, 3), 3 => 3)/cpu/reverse/Flux/(64, 64, 3, 128) |
107205890.5 ns |
77844074 ns |
1.38 |
Conv((3, 3), 3 => 3)/cpu/reverse/SimpleChains/(64, 64, 3, 128) |
11908867 ns |
11625561 ns |
1.02 |
Conv((3, 3), 3 => 3)/cpu/reverse/Enzyme/(64, 64, 3, 128) |
17730275 ns |
17676858 ns |
1.00 |
Conv((3, 3), 3 => 3)/cpu/forward/NamedTuple/(64, 64, 3, 128) |
6939771 ns |
7012256 ns |
0.99 |
Conv((3, 3), 3 => 3)/cpu/forward/ComponentArray/(64, 64, 3, 128) |
6905537.5 ns |
6974406 ns |
0.99 |
Conv((3, 3), 3 => 3)/cpu/forward/Flux/(64, 64, 3, 128) |
18581089 ns |
12040636 ns |
1.54 |
Conv((3, 3), 3 => 3)/cpu/forward/SimpleChains/(64, 64, 3, 128) |
6381444 ns |
6384692.5 ns |
1.00 |
vgg16/cpu/reverse/Zygote/(32, 32, 3, 16) |
754991377 ns |
730728458 ns |
1.03 |
vgg16/cpu/reverse/Zygote/(32, 32, 3, 64) |
2565939479 ns |
2591338002 ns |
0.99 |
vgg16/cpu/reverse/Zygote/(32, 32, 3, 2) |
144968199 ns |
143009334 ns |
1.01 |
vgg16/cpu/reverse/Tracker/(32, 32, 3, 16) |
886042638 ns |
794541938 ns |
1.12 |
vgg16/cpu/reverse/Tracker/(32, 32, 3, 64) |
3324778619 ns |
3135889035 ns |
1.06 |
vgg16/cpu/reverse/Tracker/(32, 32, 3, 2) |
237223142.5 ns |
190378633 ns |
1.25 |
vgg16/cpu/reverse/Flux/(32, 32, 3, 16) |
738294610.5 ns |
723160298 ns |
1.02 |
vgg16/cpu/reverse/Flux/(32, 32, 3, 64) |
2807281979 ns |
2554330279 ns |
1.10 |
vgg16/cpu/reverse/Flux/(32, 32, 3, 2) |
133353294 ns |
140695623.5 ns |
0.95 |
vgg16/cpu/forward/NamedTuple/(32, 32, 3, 16) |
173305684 ns |
173901954.5 ns |
1.00 |
vgg16/cpu/forward/NamedTuple/(32, 32, 3, 64) |
646469793.5 ns |
645195172 ns |
1.00 |
vgg16/cpu/forward/NamedTuple/(32, 32, 3, 2) |
34436573 ns |
34440362 ns |
1.00 |
vgg16/cpu/forward/ComponentArray/(32, 32, 3, 16) |
164333767 ns |
164466702 ns |
1.00 |
vgg16/cpu/forward/ComponentArray/(32, 32, 3, 64) |
641554492 ns |
638304093 ns |
1.01 |
vgg16/cpu/forward/ComponentArray/(32, 32, 3, 2) |
30001146 ns |
30396084 ns |
0.99 |
vgg16/cpu/forward/Flux/(32, 32, 3, 16) |
228378580 ns |
212241551.5 ns |
1.08 |
vgg16/cpu/forward/Flux/(32, 32, 3, 64) |
816119482.5 ns |
752231052 ns |
1.08 |
vgg16/cpu/forward/Flux/(32, 32, 3, 2) |
40237113 ns |
37094332 ns |
1.08 |
Conv((3, 3), 64 => 64)/cpu/reverse/ReverseDiff (compiled)/(64, 64, 64, 128) |
1263694931 ns |
1221210069 ns |
1.03 |
Conv((3, 3), 64 => 64)/cpu/reverse/Zygote/(64, 64, 64, 128) |
1849450921.5 ns |
1867251684 ns |
0.99 |
Conv((3, 3), 64 => 64)/cpu/reverse/Tracker/(64, 64, 64, 128) |
2554486900 ns |
2413480227 ns |
1.06 |
Conv((3, 3), 64 => 64)/cpu/reverse/ReverseDiff/(64, 64, 64, 128) |
2580141237 ns |
2577680676 ns |
1.00 |
Conv((3, 3), 64 => 64)/cpu/reverse/Flux/(64, 64, 64, 128) |
1861746835 ns |
1891138627 ns |
0.98 |
Conv((3, 3), 64 => 64)/cpu/reverse/Enzyme/(64, 64, 64, 128) |
561906139 ns |
557463196 ns |
1.01 |
Conv((3, 3), 64 => 64)/cpu/forward/NamedTuple/(64, 64, 64, 128) |
317367635 ns |
320116498 ns |
0.99 |
Conv((3, 3), 64 => 64)/cpu/forward/ComponentArray/(64, 64, 64, 128) |
319114093 ns |
322064014 ns |
0.99 |
Conv((3, 3), 64 => 64)/cpu/forward/Flux/(64, 64, 64, 128) |
439837259 ns |
371601085 ns |
1.18 |
Conv((3, 3), 1 => 1)/cpu/reverse/ReverseDiff (compiled)/(64, 64, 1, 128) |
11738585 ns |
11849717 ns |
0.99 |
Conv((3, 3), 1 => 1)/cpu/reverse/Zygote/(64, 64, 1, 128) |
17784264 ns |
17757350 ns |
1.00 |
Conv((3, 3), 1 => 1)/cpu/reverse/Tracker/(64, 64, 1, 128) |
19050509 ns |
19083212 ns |
1.00 |
Conv((3, 3), 1 => 1)/cpu/reverse/ReverseDiff/(64, 64, 1, 128) |
23770011.5 ns |
23790378.5 ns |
1.00 |
Conv((3, 3), 1 => 1)/cpu/reverse/Flux/(64, 64, 1, 128) |
17833455.5 ns |
17795152 ns |
1.00 |
Conv((3, 3), 1 => 1)/cpu/reverse/SimpleChains/(64, 64, 1, 128) |
1164092 ns |
1160445 ns |
1.00 |
Conv((3, 3), 1 => 1)/cpu/reverse/Enzyme/(64, 64, 1, 128) |
5767964 ns |
5795907.5 ns |
1.00 |
Conv((3, 3), 1 => 1)/cpu/forward/NamedTuple/(64, 64, 1, 128) |
2041566 ns |
2043511 ns |
1.00 |
Conv((3, 3), 1 => 1)/cpu/forward/ComponentArray/(64, 64, 1, 128) |
2022397.5 ns |
2025624.5 ns |
1.00 |
Conv((3, 3), 1 => 1)/cpu/forward/Flux/(64, 64, 1, 128) |
2067538 ns |
2068152 ns |
1.00 |
Conv((3, 3), 1 => 1)/cpu/forward/SimpleChains/(64, 64, 1, 128) |
195994 ns |
197954 ns |
0.99 |
Dense(200 => 200)/cpu/reverse/ReverseDiff (compiled)/(200, 128) |
292764 ns |
294058 ns |
1.00 |
Dense(200 => 200)/cpu/reverse/Zygote/(200, 128) |
267226 ns |
266246.5 ns |
1.00 |
Dense(200 => 200)/cpu/reverse/Tracker/(200, 128) |
368354 ns |
369049 ns |
1.00 |
Dense(200 => 200)/cpu/reverse/ReverseDiff/(200, 128) |
410553 ns |
410075 ns |
1.00 |
Dense(200 => 200)/cpu/reverse/Flux/(200, 128) |
275381.5 ns |
276486 ns |
1.00 |
Dense(200 => 200)/cpu/reverse/SimpleChains/(200, 128) |
407947 ns |
409464 ns |
1.00 |
Dense(200 => 200)/cpu/reverse/Enzyme/(200, 128) |
83616 ns |
83486 ns |
1.00 |
Dense(200 => 200)/cpu/forward/NamedTuple/(200, 128) |
82614 ns |
81973 ns |
1.01 |
Dense(200 => 200)/cpu/forward/ComponentArray/(200, 128) |
82653 ns |
82293 ns |
1.00 |
Dense(200 => 200)/cpu/forward/Flux/(200, 128) |
87222 ns |
87123 ns |
1.00 |
Dense(200 => 200)/cpu/forward/SimpleChains/(200, 128) |
104274 ns |
104505 ns |
1.00 |
Conv((3, 3), 16 => 16)/cpu/reverse/ReverseDiff (compiled)/(64, 64, 16, 128) |
208208086 ns |
197238400.5 ns |
1.06 |
Conv((3, 3), 16 => 16)/cpu/reverse/Zygote/(64, 64, 16, 128) |
326893345.5 ns |
323621438.5 ns |
1.01 |
Conv((3, 3), 16 => 16)/cpu/reverse/Tracker/(64, 64, 16, 128) |
448627333 ns |
415301093.5 ns |
1.08 |
Conv((3, 3), 16 => 16)/cpu/reverse/ReverseDiff/(64, 64, 16, 128) |
450456838.5 ns |
455834085 ns |
0.99 |
Conv((3, 3), 16 => 16)/cpu/reverse/Flux/(64, 64, 16, 128) |
421141441.5 ns |
385807373 ns |
1.09 |
Conv((3, 3), 16 => 16)/cpu/reverse/SimpleChains/(64, 64, 16, 128) |
348199120 ns |
325059749.5 ns |
1.07 |
Conv((3, 3), 16 => 16)/cpu/reverse/Enzyme/(64, 64, 16, 128) |
101166366 ns |
101180781.5 ns |
1.00 |
Conv((3, 3), 16 => 16)/cpu/forward/NamedTuple/(64, 64, 16, 128) |
43851539 ns |
43939761 ns |
1.00 |
Conv((3, 3), 16 => 16)/cpu/forward/ComponentArray/(64, 64, 16, 128) |
43907728.5 ns |
43616881 ns |
1.01 |
Conv((3, 3), 16 => 16)/cpu/forward/Flux/(64, 64, 16, 128) |
57731447 ns |
50973340 ns |
1.13 |
Conv((3, 3), 16 => 16)/cpu/forward/SimpleChains/(64, 64, 16, 128) |
28662597.5 ns |
28424655.5 ns |
1.01 |
Dense(2000 => 2000)/cpu/reverse/ReverseDiff (compiled)/(2000, 128) |
18963024.5 ns |
18965595 ns |
1.00 |
Dense(2000 => 2000)/cpu/reverse/Zygote/(2000, 128) |
19539252.5 ns |
19621446 ns |
1.00 |
Dense(2000 => 2000)/cpu/reverse/Tracker/(2000, 128) |
23311263 ns |
23721256 ns |
0.98 |
Dense(2000 => 2000)/cpu/reverse/ReverseDiff/(2000, 128) |
24109250 ns |
24311100.5 ns |
0.99 |
Dense(2000 => 2000)/cpu/reverse/Flux/(2000, 128) |
19612279.5 ns |
19725432 ns |
0.99 |
Dense(2000 => 2000)/cpu/reverse/Enzyme/(2000, 128) |
6520025.5 ns |
6539089.5 ns |
1.00 |
Dense(2000 => 2000)/cpu/forward/NamedTuple/(2000, 128) |
6513794 ns |
6553537 ns |
0.99 |
Dense(2000 => 2000)/cpu/forward/ComponentArray/(2000, 128) |
6523171 ns |
6501922.5 ns |
1.00 |
Dense(2000 => 2000)/cpu/forward/Flux/(2000, 128) |
6550963 ns |
6518066 ns |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
74cffe1
to
1d7dc93
Compare
27e3deb
to
63bb0e7
Compare
This pull request changes the compat entry for the
AMDGPU
package from0.8.4 - 0.9.4
to0.8.4 - 0.9.4, 0.9
.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.