Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify CardMonitoring's deleteObserver method to cleanly remove threads #54

Closed
wants to merge 1 commit into from
Closed

Modify CardMonitoring's deleteObserver method to cleanly remove threads #54

wants to merge 1 commit into from

Conversation

merrickheley
Copy link
Contributor

This closes #53

@coveralls
Copy link

coveralls commented Nov 26, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.05%) to 23.921% when pulling 1f07846 on merrickheley:join-rmthreads-with-no-observers into 55fc8f1 on LudovicRousseau:master.

@LudovicRousseau
Copy link
Owner

Fixed in b9accdb

Thanks

@merrickheley merrickheley deleted the join-rmthreads-with-no-observers branch November 27, 2017 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rmthread should be cleaned up when the last observer is removed
3 participants
@merrickheley @coveralls @LudovicRousseau