Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Windows binaries also for Python 3.11 #148

Closed
wants to merge 2 commits into from
Closed

Build Windows binaries also for Python 3.11 #148

wants to merge 2 commits into from

Conversation

bittner
Copy link
Contributor

@bittner bittner commented Feb 20, 2023

Makes pyscard available for Python 3.11 as a downloadable installation artifact.

@coveralls
Copy link

coveralls commented Feb 20, 2023

Coverage Status

Coverage: 28.576%. Remained the same when pulling 1041661 on bittner:feature/python3.11-windows into 430b591 on LudovicRousseau:master.

@bittner
Copy link
Contributor Author

bittner commented Feb 21, 2023

Seems to work fine on AppVeyor.

@bittner
Copy link
Contributor Author

bittner commented Feb 21, 2023

Looks good! Ready to merge. 🚀

@LudovicRousseau
Copy link
Owner

OK to add support of Python 3.11

But if the generation of MSI is disabled in recent versions of setuptools then I propose to drop the generation of MSI installers.
Working with an old version of setuptools will bring issues in the future.

@bittner
Copy link
Contributor Author

bittner commented Feb 21, 2023

But if the generation of MSI is disabled in recent versions of setuptools then I propose to drop the generation of MSI installers.

I tend to agree, but I don't think it's that critical of an issue. Setuptools is so widespread and rather old versions still work; I noticed this on some older projects of mine, especially when you build packages for older Python versions.

Personally, I would suggest to let this be the last shot of building EXE installers and MSI binaries and announce that EXE and MSI's may be discontinued in future. Currently, the build process for Windows runs both on AppVeyor and on GitHub Actions; you likely want to (consolidate or) remove this anyway, some day.

Working with an old version of setuptools will bring issues in the future.

Note that the changes in this PR only ensure an older version for building the Windows EXE and MSI binaries. The artifacts that are uploaded to PyPI (and installed using pip) are not affected. (EDIT: I just noticed that's not true, but it would be easy to make it that way.)

I'm not a fan of Mircosoft Windos, but let's keep it simple for their folks, as long as we can.

@LudovicRousseau
Copy link
Owner

Partly merged in 874603a

@bittner bittner deleted the feature/python3.11-windows branch February 22, 2023 08:37
@bittner
Copy link
Contributor Author

bittner commented Feb 22, 2023

Good choice to remove building the EXE installer and the MSI! 👍 (I figured using them caused the dependency problems I originally came here for. 💡)

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants