Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup, consolidate and propose minor version bump #1

Closed
wants to merge 26 commits into from
Closed

Cleanup, consolidate and propose minor version bump #1

wants to merge 26 commits into from

Conversation

moreati
Copy link
Contributor

@moreati moreati commented Jun 23, 2015

Sorry it's all at once, I'm still learning GitHub's UI. If this is too much just reject it and I'll figure out how to break it into smaller chunks.

This pull request

  • Removes support for Python prior to 2.6
  • Removes support for OS X prior to 10.6 (Snow Leopard), including #ifdefs for TIGER
  • Proposes 1.7.0 as the next pyscard release
  • Makes setup.py the single source of truth for pyscard's version
  • Moves the Changelog, TODO and ACKS into the project root
  • Deletes the duplicate README and LICENCE in smartcard/
  • Adds smartcard.pyro to distributed packages
  • Switches to setuptools for build/packaging
  • Adds initial support for building pyscard on Appveyor and Travis
  • Tightens try/except blocks to avoid catching e.g. SystemExit, SyntaxError
  • Adds initial pylint configuration
  • Fixes several major errors and warnings found with pylint
  • Reformats the supported methods/attributes docstrings in pyscard.i as tables

@moreati
Remove support for Python releases older than 2.6
565db70
@moreati
Consolidate build platform logic
ac3eb31 
This also fixes Mac OS X Lion options being selected on Snow Leopard -
due to misordered of elif blocks.
@moreati
Standardise Trove classifiers, declare OS & Python support
3bca937
@moreati
Correct package declarations, include smartcard.pyro
119b0f2
@moreati
Switch from distutils to setuptools
a72aa55
@moreati
Add gitignore for build artefacts
20c77ff
@moreati
Initial attempt at CI builds on Windows, using appveyor.com
7d36645 
Instructions at https://packaging.python.org/en/latest/appveyor.html
@moreati
Missing comment
7b0005e
@moreati
Download and install Swig in CI build
88c556c
@moreati
Merge branch 'master' of github.com:moreati/pyscard
1375471
@moreati
First attempt at Travis CI
af2c0e0
@moreati
Correct travis dependcy installation
31241d9 
Based on http:https://docs.travis-ci.com/user/installing-dependencies/
@moreati
sudo helps when running apt-get
17feb6c
@moreati
gitignore the config generated by the test suite
cae9467
@moreati
Remove all but two uses of 'except:' & 'except Exception:'
370427c 
The remaining instance will now print a full traceback. This should
improve on with https://sourceforge.net/p/pyscard/bugs/8/, or at least
make it easier to solve
@moreati
Commit convert docstring examples to doctest syntax
bedaf68
@moreati
Add default pylint config
7479bf1
@moreati
Customize pylintrc
7b25b21
@moreati
Fix most major pylint errors and warnings
e1bba4b 
5 undefined variables remain unfixed, they appear to be missing
`smartcard.scard.scard` exports
```
************* Module smartcard.pcsc.PCSCReader
E: 67,22: Undefined variable 'SCardIntroduceReader' (undefined-variable)
E: 70,22: Undefined variable 'SCardAddReaderToGroup' (undefined-
variable)
E: 85,22: Undefined variable 'SCardRemoveReaderFromGroup' (undefined-
variable)
************* Module smartcard.pcsc.PCSCReaderGroups
E: 66,22: Undefined variable 'SCardIntroduceReaderGroup' (undefined-
variable)
E: 90,22: Undefined variable 'SCardForgetReaderGroup' (undefined-
variable)
```
@moreati
Merge branch 'master' of github.com:LudovicRousseau/pyscard
173d961
@moreati
Consolidate Changelog, LICENSE, README etc into root dir. Delete PKG-…
568d577 
…INFO

PKG-INFO and included in the sdist package each time setup.py is run.
Storing it in source control is redundant.
@moreati
Remove code supporting OS X Tiger
5c50b3f
@moreati
Reformat functions/attributes supported by smartcard.scard as tables
fdadf6e
@moreati
Consolidate the project version in setup.py, bump to 1.7.0
2fb346a
@LudovicRousseau
Copy link
Owner

Woua!
I will cherry-pick and reorganise the patches.

@LudovicRousseau
Copy link
Owner

I rebased your patches above master and committed all of them except 2:

These 2 patches are too big and mix different unrelated modifications. They will also conflict with the python3 branch so they will need to be reworked. I propose to postpone these 2 patches for now.

@LudovicRousseau
Copy link
Owner

Most of the patches applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@moreati @LudovicRousseau