Skip to content

Commit

Permalink
cppcheck: Variable 'rv' is reassigned a value before the old one has
Browse files Browse the repository at this point in the history
been used.

This is a (minor) performance issue. I guess the compiler can optimize
the code as needed.


git-svn-id: svn:https://anonscm.debian.org/svn/pcsclite/trunk/PCSC@6558 0ce88b0d-b2fd-0310-8134-9614164e65ea
  • Loading branch information
LudovicRousseau committed Mar 6, 2013
1 parent c9dfe6e commit 287b5a8
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions src/ifdwrapper.c
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
LONG IFDSetPTS(READER_CONTEXT * rContext, DWORD dwProtocol, UCHAR ucFlags,
UCHAR ucPTS1, UCHAR ucPTS2, UCHAR ucPTS3)
{
RESPONSECODE rv = IFD_SUCCESS;
RESPONSECODE rv;

#ifndef PCSCLITE_STATIC_DRIVER
RESPONSECODE(*IFDH_set_protocol_parameters) (DWORD, DWORD, UCHAR,
Expand Down Expand Up @@ -141,7 +141,7 @@ LONG IFDOpenIFD(READER_CONTEXT * rContext)
*/
LONG IFDCloseIFD(READER_CONTEXT * rContext)
{
RESPONSECODE rv = IFD_SUCCESS;
RESPONSECODE rv;
int repeat;

#ifndef PCSCLITE_STATIC_DRIVER
Expand Down Expand Up @@ -183,7 +183,7 @@ LONG IFDCloseIFD(READER_CONTEXT * rContext)
LONG IFDSetCapabilities(READER_CONTEXT * rContext, DWORD dwTag,
DWORD dwLength, PUCHAR pucValue)
{
RESPONSECODE rv = IFD_SUCCESS;
RESPONSECODE rv;

#ifndef PCSCLITE_STATIC_DRIVER
RESPONSECODE(*IFDH_set_capabilities) (DWORD, DWORD, DWORD, PUCHAR) = NULL;
Expand Down Expand Up @@ -214,7 +214,7 @@ LONG IFDSetCapabilities(READER_CONTEXT * rContext, DWORD dwTag,
LONG IFDGetCapabilities(READER_CONTEXT * rContext, DWORD dwTag,
PDWORD pdwLength, PUCHAR pucValue)
{
RESPONSECODE rv = IFD_SUCCESS;
RESPONSECODE rv;

#ifndef PCSCLITE_STATIC_DRIVER
RESPONSECODE(*IFDH_get_capabilities) (DWORD, DWORD, PDWORD, /*@out@*/ PUCHAR) = NULL;
Expand Down Expand Up @@ -317,7 +317,7 @@ LONG IFDPowerICC(READER_CONTEXT * rContext, DWORD dwAction,
*/
LONG IFDStatusICC(READER_CONTEXT * rContext, PDWORD pdwStatus)
{
RESPONSECODE rv = IFD_SUCCESS;
RESPONSECODE rv;
DWORD dwCardStatus = 0;

#ifndef PCSCLITE_STATIC_DRIVER
Expand Down Expand Up @@ -487,7 +487,7 @@ LONG IFDTransmit(READER_CONTEXT * rContext, SCARD_IO_HEADER pioTxPci,
PUCHAR pucTxBuffer, DWORD dwTxLength, PUCHAR pucRxBuffer,
PDWORD pdwRxLength, PSCARD_IO_HEADER pioRxPci)
{
RESPONSECODE rv = IFD_SUCCESS;
RESPONSECODE rv;

#ifndef PCSCLITE_STATIC_DRIVER
RESPONSECODE(*IFDH_transmit_to_icc) (DWORD, SCARD_IO_HEADER, PUCHAR,
Expand Down

0 comments on commit 287b5a8

Please sign in to comment.