Allow vendor control commands for Omnikey 5427 CK #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, the PC/SC protocol doesn't allow sending commands (APDUs) to a reader that doesn't have a card inserted. There's a legitimate use case (which exactly, isn't relevant here) for supporting this for the Omnikey 5427 CK reader. This reader provides a capability for sending APDUs, but only via a vendor control command. By default, vendor control commands are forbidden, and can be enabled for all readers via setting the "ifdDriverOptions" parameter in the Info.plist config to have the bit "1" (DRIVER_OPTION_CCID_EXCHANGE_AUTHORIZED). However, enabling this parametere in the config might impose a security risk when using some readers and applications (see https://ludovicrousseau.blogspot.com/2011/10/featureccidesccommand.html). Hence the solution in this commit is to special-case the Omnikey 5427 CK reader and allow any application to send control commands. It was confirmed with the reader's vendor that this doesn't impose a security risk here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the PC/SC protocol doesn't allow sending commands (APDUs) to
a reader that doesn't have a card inserted. There's a legitimate use
case (which exactly, isn't relevant here) for supporting this for the
Omnikey 5427 CK reader.
This reader provides a capability for sending APDUs, but only via a
vendor control command. By default, vendor control commands are
forbidden, and can be enabled for all readers via setting the
"ifdDriverOptions" parameter in the Info.plist config to have the bit
"1" (DRIVER_OPTION_CCID_EXCHANGE_AUTHORIZED). However, enabling this
parametere in the config might impose a security risk when using some
readers and applications (see
https://ludovicrousseau.blogspot.com/2011/10/featureccidesccommand.html).
Hence the solution in this commit is to special-case the Omnikey 5427
CK reader and allow any application to send control commands. It was
confirmed with the reader's vendor that this doesn't impose a security
risk here.