Fix for unsupported commands: GET_CLOCK_FREQUENCIES and improvement of previous fix for GET_DATA_RATES #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… data rates: commit b00292f Author: Ludovic Rousseau <[email protected]> Date: Sat Mar 27 18:46:15 2021 +0100 ccid_usb: ask for bNumDataRatesSupported data rates Some devices set bNumDataRatesSupported to a value different from 0 but libusb_control_transfer() fails if another value (like 256) is used. The Alcor Micro 9540 is such a reader. commit 19b9e92 (HEAD -> master, origin/master, origin/HEAD) Author: Ludovic Rousseau <[email protected]> Date: Sun Apr 4 19:04:10 2021 +0200 get_data_rates(): fix bug if bNumDataRatesSupported > 0 The bug was introduced in b00292f (not released in a stable version) Thanks to Godfrey Chung got the bug report b00292f#r49087277 ------- These fixes seem also needed on the following reader: Bit4Id miniLector AIR NFC v3 (25DD:3403). Signed-off-by: Guido Trentalancia <[email protected]>
Some devices set bNumClockSupported to a value different from 0 but libusb_control_transfer() fails if another value (like 256) is used. The Bit4Id miniLector AIR NFC v3 (25DD:3403) seems to need this fix. Signed-off-by: Guido Trentalancia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to fix the case of two commands possibly unsupported by some readers:
GET_CLOCK_FREQUENCIES (bNumClockSupported) - new fix
GET_DATA_RATES (bNumDataRatesSupported) - code style improvement of previous fix
Both fixes seem to be needed at least on the following reader: Bit4Id miniLector AIR NFC v3 (25DD:3403).